From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5LwLL6eguGBuFQAAWB0awg (envelope-from ) for ; Thu, 03 Jun 2021 05:28:07 -0400 Received: by simark.ca (Postfix, from userid 112) id B040B1F163; Thu, 3 Jun 2021 05:28:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CDCAE1E01F for ; Thu, 3 Jun 2021 05:28:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 343C7398B173 for ; Thu, 3 Jun 2021 09:28:06 +0000 (GMT) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 4B33E386FC04 for ; Thu, 3 Jun 2021 09:27:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B33E386FC04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x430.google.com with SMTP id z8so5083115wrp.12 for ; Thu, 03 Jun 2021 02:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7UP51rMFy0pZ13Ye32AWKpe8p1qRMnHa8wicOO9TuFM=; b=UzEhlDEPwZ/OvU8iiyFdoGq4bwuNAX3LDQko9fqaA2beRqOCa7P3HYxR69W/EZu5qb siMq9SOJONFwvFn6jplhxLz/ftuNmkOspTcjY7vX0UZI1EDfY+Sf7OizYWhMLMQ8iGlN J84XyB0c5XUf4B4fsqB+MQRO7N5YRJddoGjAzyEveGpA5Br5fCY1rt1argx3daPJtycq vlaYuffLHM4JTFhoawLYfbxMYMhQo/jWfM1oc0SFXXnTkRoYWlS5+zX4gtVp/YdkbkPs 2skkQpkUNdFCQoYobcyE7++bxX084Gp3/U/4bfJP1KHjFAI5r8XbrvkvoO50mLiKgqWB iT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7UP51rMFy0pZ13Ye32AWKpe8p1qRMnHa8wicOO9TuFM=; b=VigCYp7VLpj0xYYao0kVcIhIh7BpW+T+r83m1Da/8MkZlCJYJDkdwkzGGErZDMSdxl l760WAAmQaLZSBx+J/qttR7Tp8Fvnycs1n/BAozY57czOWCgRqnWWcT7ycgk1YFt/Agr QCXgZwbpNMzET7NuMVYj5IY7yX0Qb/PxKw6rYGLATMlULSVHytV1CjKvOzFiHISdA78c QBVaXjdjC1NnIBqzWxFDCPGSbr4Rhw0Mt+sCop1grqTL+f5+YydkuaooZqDs/z3++7FE MviFWzKiZj9/+mFCqfEYF5awTR26UbhqTkXqXOJdnH4FhUdaXGUh3HA0kkKeSUQwQIxb 2DRg== X-Gm-Message-State: AOAM530CNxMWyC3PTuIrHxRYhkXItBKhiWwN4hxMyVbNLMELB2dJOvqL 3auycPOPkf+p6EokFz4R83EjoHp1KQ9fyQ== X-Google-Smtp-Source: ABdhPJxrlP1HcNjGmFaShh2YF9HctCMUHemY5p+8lFWiFYT2xLN+Q95AmH4T37ku+HoW+UI0bIdrvA== X-Received: by 2002:a05:6000:2c4:: with SMTP id o4mr6027350wry.267.1622712473221; Thu, 03 Jun 2021 02:27:53 -0700 (PDT) Received: from localhost (host109-151-46-70.range109-151.btcentralplus.com. [109.151.46.70]) by smtp.gmail.com with ESMTPSA id n9sm3123269wrt.81.2021.06.03.02.27.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 02:27:52 -0700 (PDT) Date: Thu, 3 Jun 2021 10:27:52 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv2 0/5] "info sources" - group by objfile Message-ID: <20210603092752.GN2672@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 10:26:45 up 14 days, 23:10, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Ping! Any thoughts on the new approach? Specifically, changing the behaviour of CLI 'info sources'? Thanks, Andrew * Andrew Burgess [2021-05-19 12:12:37 +0100]: > Thanks for all the great feedback. > > In V2: > > - Documentation talks about object files rather than binaries, I also > fixed the other doc issues Eli pointed out. > > - Renamed the new quick function in patch #1 to > has_unexpanded_symtabs as suggested. The resuling > objfile::has_unexpanded_symtabs function now has debug print out > like other quick function wrapper functions. > > - The commit message that adds the new MI option has some example > output. > > - Instead of adding a new option for CLI "info sources", the output > format has been changed. > > - Other minor code issues have been cleaned up. > > Of note: > > - The new objfile::has_unexpanded_symtabs is still in symfile-debug.c > rather than objfile.c as Tom suggested. This ensures that this > quick function wrapper is in the same source file as all the other > wrapper functions. I think we should move all of them together, or > not at all, and if they do all move it feels like it should be a > separate, follow-up commit. > > Thanks, > Andrew > > > --- > > Andrew Burgess (5): > gdb: add new function quick_symbol_functions::has_unexpanded_symbols > gdb: make struct output_source_filename_data more C++ like > gdb/mi: add regexp filtering to -file-list-exec-source-files > gdb/mi: add new --group-by-objfile flag for > -file-list-exec-source-files > gdb: change info sources to group results by objfile > > gdb/ChangeLog | 111 ++++++ > gdb/NEWS | 30 ++ > gdb/doc/ChangeLog | 15 + > gdb/doc/gdb.texinfo | 166 +++++++-- > gdb/dwarf2/read.c | 22 ++ > gdb/mi/mi-cmd-file.c | 92 +++-- > gdb/objfiles.h | 6 + > gdb/psympriv.h | 2 + > gdb/psymtab.c | 18 + > gdb/quick-symbol.h | 6 + > gdb/symfile-debug.c | 25 ++ > gdb/symtab.c | 349 +++++++++++------- > gdb/symtab.h | 59 +++ > gdb/testsuite/ChangeLog | 19 + > .../gdb.base/info_sources_2-header.h | 28 ++ > gdb/testsuite/gdb.base/info_sources_2-lib.c | 25 ++ > gdb/testsuite/gdb.base/info_sources_2-test.c | 26 ++ > gdb/testsuite/gdb.base/info_sources_2.exp | 169 +++++++++ > gdb/testsuite/gdb.dwarf2/dw2-filename.exp | 2 +- > gdb/testsuite/gdb.mi/mi-file.exp | 2 +- > gdb/testsuite/gdb.mi/mi-info-sources-base.c | 23 ++ > gdb/testsuite/gdb.mi/mi-info-sources.c | 25 ++ > gdb/testsuite/gdb.mi/mi-info-sources.exp | 177 +++++++++ > 23 files changed, 1205 insertions(+), 192 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-header.h > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-lib.c > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-test.c > create mode 100644 gdb/testsuite/gdb.base/info_sources_2.exp > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources-base.c > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.c > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.exp > > -- > 2.25.4 >