Re: [PATCH 3/4] gdb: add new -group-by-binary flag to info sources command

[Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>]

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Mon, 26 Apr 2021 18:07:02 +0100
> 
> +info sources [-group-by-binary] [-dirname] [-basename] [REGEXP]
> +  The 'info sources' command now supports a new flag
> +  '-group-by-binary'.  When this flag is supplied the results are
> +  formatted as a list of loaded binaries followed by the source files
> +  for each binary.  A single source file can appear multiple times in
> +  the output if it is part of multiple binaries.

I'm worried about the confusion we will cause by the "binary"
terminology.  Elsewhere we call these "object files"; see, for
example, "Auto-loading sequences".  Can we keep our terminology
consistent?

> +When the optional @code{-group-by-binary} flag is given then the
> +output is organized as a list of the binaries currently loaded into
> +@value{GDBN}, for each binary, all of the source files associated with
> +that binary are given.  A single source file can be repeated in this
> +output format, if it is part of multiple binaries.

And here you don't even explain what is a "binary" for this purpose.

> +If the optional @var{regexp} is provided, then only source files that
> +match the regular expression will be printed.  The matching is
> +case-sensitive, except on operating systems that have case-insensitive
> +filesystem (e.g., MS-Windows). @samp{--} can be used before
> +@var{regexp} to prevent @value{GDBN} interpreting @var{regexp} as a
> +command option (e.g. if @var{regexp} starts with @samp{-}).

I wonder how the new output will look when REGEXP is given.  Suppose
some binary has no sources that match the regexp: will that binary
appear with an empty list of source files, or will it not appear at
all?  And if the latter, isn't it confusing?

Thanks.