From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rYk8CyX6pGBkOAAAWB0awg (envelope-from ) for ; Wed, 19 May 2021 07:44:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 21DD51F11C; Wed, 19 May 2021 07:44:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 58FB61E54D for ; Wed, 19 May 2021 07:44:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C36C53857C48; Wed, 19 May 2021 11:44:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C36C53857C48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621424675; bh=sZQzAn1BtrQt/KmDO3/G2wUiw6TsdN+oTISMZqq3B4A=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=EvBx5ktufJ7chol40JVt9r3wR6QLuYeYb2dMBHt7Jj99aXWxl8pfJMNBTRC35NHod gRuTshVT4HfKuBUS9wyTGrLSI1q1d9GQIfqpi3jcV7S9i21CwT0IZz0dqS9XGjCwbt 26GzWEbAz8az5WQ69mlzVQWamHKRcMGRoLy+BqmI= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 94BAC3857C48 for ; Wed, 19 May 2021 11:44:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 94BAC3857C48 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45502) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljKcq-0002Gk-5W; Wed, 19 May 2021 07:44:32 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2365 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljKcp-0001kM-A5; Wed, 19 May 2021 07:44:32 -0400 Date: Wed, 19 May 2021 14:44:38 +0300 Message-Id: <83bl97q76h.fsf@gnu.org> To: Andrew Burgess In-Reply-To: <262bab9f91a72af816095a01628e7cd9ac3e48ba.1621421987.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Wed, 19 May 2021 12:12:41 +0100) Subject: Re: [PATCHv2 4/5] gdb/mi: add new --group-by-objfile flag for -file-list-exec-source-files References: <262bab9f91a72af816095a01628e7cd9ac3e48ba.1621421987.git.andrew.burgess@embecosm.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Andrew Burgess > Date: Wed, 19 May 2021 12:12:41 +0100 > > diff --git a/gdb/NEWS b/gdb/NEWS > index aae0d5b025a..77dd2fac082 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -46,7 +46,9 @@ > all locations of the selected breakpoint. This is equivalent to > the '-force' flag of the CLI's "cond" command. > > - ** '-file-list-exec-source-files [--basename | --dirname] [--] [REGEXP]' > + ** '-file-list-exec-source-files [--group-by-objfile] > + [--basename | --dirname] > + [--] [REGEXP]' > > The existing -file-list-exec-source-files command now takes an > optional REGEXP which is used to filter the source files that are > @@ -56,6 +58,11 @@ > When one of --basename or --dirname is given then REGEXP is only > matched against the specified part of the full source filename. > > + When the optional --group-by-objfile flag is used the output > + format is changed, the results are now a list of object files > + (executable and libraries) with the source files that are > + associated with each object file. > + > The results from -file-list-exec-source-files now include a > 'debug-fully-read' field which takes the value 'true' or 'false'. > A 'true' value indicates the source file is from a compilation This part is OK. > +If @code{--group-by-objfile} is used then the format of the results is > +changed. The results will now be a list of tuples, with each tuple > +representing an object file (executable or shared libraries) loaded ^^^^^^^^^ "library", in singular. Other than that, the patch for the manual is also OK. Thanks.