* New ARI warning Wed Oct 2 01:56:22 UTC 2019
@ 2019-10-02 1:56 GDB Administrator
2019-10-02 2:50 ` Simon Marchi
0 siblings, 1 reply; 10+ messages in thread
From: GDB Administrator @ 2019-10-02 1:56 UTC (permalink / raw)
To: gdb-patches
4a5,6
> gdb/ada-lang.c:3881: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/ada-lang.c:3881: printf_filtered (_(" at %p[<no source file available>%p]:%d\n"),
> gdb/ada-lang.c:3885: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/ada-lang.c:3885: (_(" at %ps:%d\n"),
9a12,13
> gdb/ada-valprint.c:241: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/ada-valprint.c:241: fprintf_filtered (stream, _(" %p[<repeats %u times>%p]"),
> gdb/ada-valprint.c:532: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/ada-valprint.c:532: fprintf_filtered (stream, _(" %p[<repeats %u times>%p]"),
34a39,45
> gdb/auto-load.c:494: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/auto-load.c:494: warning (_("File \"%ps\" auto-loading has been declined by your "
> gdb/auto-load.c:994: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/auto-load.c:994:of file %ps."),
> gdb/auto-load.c:1127: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/auto-load.c:1127: warning (_("Couldn't read %s section of %ps"),
> gdb/auto-load.c:1358: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/auto-load.c:1358: printf_filtered (_("Local .gdbinit file \"%ps\" has been loaded.\n"),
> gdb/auto-load.c:1362: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/auto-load.c:1362: printf_filtered (_("Local .gdbinit file \"%ps\" has not been loaded.\n"),
> gdb/auto-load.c:1381: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/auto-load.c:1381:of file %ps.\n\
> gdb/auto-load.c:1405: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/auto-load.c:1405:of file %ps.\n\
35a47,50
> gdb/breakpoint.c:4915: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:4915: uiout->message ("\nWatchpoint %pF deleted because the program has "
> gdb/breakpoint.c:6146: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:6146: uiout->message (" (%pF evals)",
> gdb/breakpoint.c:6197: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:6197: uiout->message ("\tignore next %pF hits\n",
> gdb/breakpoint.c:6661: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:6661: current_uiout->message (_("also set at pc %ps.\n"),
37a53,57
> gdb/breakpoint.c:12078: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:12078: printf_filtered (" at %ps",
> gdb/breakpoint.c:12090: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:12090: printf_filtered (": file %ps, line %d.",
> gdb/breakpoint.c:12397: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:12397: uiout->message ("Temporary breakpoint %pF, ",
> gdb/breakpoint.c:12400: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:12400: uiout->message ("Breakpoint %pF, ",
> gdb/breakpoint.c:12717: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/breakpoint.c:12717: uiout->message ("\tmarker id is %pF\n",
38a59,65
> gdb/c-typeprint.c:1119: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/c-typeprint.c:1119: _("%p[<incomplete type>%p]\n"),
> gdb/c-typeprint.c:1123: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/c-typeprint.c:1123: _("%p[<no data fields>%p]\n"),
> gdb/c-typeprint.c:1282: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/c-typeprint.c:1282: _("%p[<undefined type>%p] %s;\n"),
> gdb/c-typeprint.c:1629: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/c-typeprint.c:1629: _("%p[<incomplete type>%p]\n"),
> gdb/c-typeprint.c:1633: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/c-typeprint.c:1633: _("%p[<no data fields>%p]\n"),
> gdb/cli/cli-cmds.c:455: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/cli/cli-cmds.c:455: printf_unfiltered (_("Working directory %ps\n (canonically %ps).\n"),
> gdb/cli/cli-cmds.c:460: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/cli/cli-cmds.c:460: printf_unfiltered (_("Working directory %ps.\n"),
51a79
> gdb/cli/cli-logging.c:33: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/cli/cli-logging.c:33: fprintf_filtered (file, _("The current logfile is \"%ps\".\n"),
288a317
> gdb/infrun.c:7661: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/infrun.c:7661: uiout->message ("[Inferior %s (%s) exited with code %pF]\n",
303a333,334
> gdb/linux-thread-db.c:938: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/linux-thread-db.c:938: _("Using host libthread_db library \"%ps\".\n"),
> gdb/linux-thread-db.c:1033: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/linux-thread-db.c:1033: " inferior, but got %ps."),
311a343
> gdb/macrocmd.c:123: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/macrocmd.c:123: fprintf_filtered (stream, "%ps:%d\n",
389a422
> gdb/p-lang.c:296: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/p-lang.c:296: fprintf_filtered (stream, " %p[<repeats %u times>%p]",
407a441,442
> gdb/printcmd.c:2004: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/printcmd.c:2004: fprintf_filtered (gdb_stdout, _("%p[<error: %s>%p]\n"),
> gdb/printcmd.c:2219: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/printcmd.c:2219: fprintf_filtered (stream, "%s%ps = ", n_spaces (2 * indent),
476a512
> gdb/rust-lang.c:477: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/rust-lang.c:477: fprintf_filtered (stream, _("%s {%p[<No data fields>%p]}"),
499a536
> gdb/stack.c:1528: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/stack.c:1528: (" (%ps:%d)",
507a545,547
> gdb/symfile.c:1109: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/symfile.c:1109: printf_filtered (_("Reading symbols from %ps...\n"),
> gdb/symfile.c:1122: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/symfile.c:1122: printf_filtered (_("Expanding full symbols from %ps...\n"),
> gdb/symfile.c:1135: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/symfile.c:1135: printf_filtered (_("(No debugging symbols found in %ps)\n"),
515a556,557
> gdb/symtab.c:4751: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/symtab.c:4751: printf_filtered (_("\nFile %ps:\n"),
> gdb/symtab.c:4820: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/symtab.c:4820: printf_filtered (_("%ps %ps\n"),
575a618
> gdb/ui-out.c:644: code: long long: Do not use 'long long', instead use LONGEST
gdb/ui-out.c:644: call_do_message (style, current_substring, va_arg (args, long long));
576a620,624
> gdb/unittests/format_pieces-selftests.c:67: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/unittests/format_pieces-selftests.c:67: check ("Hello\\t \"%p[%pF%ps%*.*d%p]\"",
> gdb/unittests/format_pieces-selftests.c:70: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/unittests/format_pieces-selftests.c:70: format_piece ("%p[", ptr_arg, 0),
> gdb/unittests/format_pieces-selftests.c:71: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/unittests/format_pieces-selftests.c:71: format_piece ("%pF", ptr_arg, 0),
> gdb/unittests/format_pieces-selftests.c:72: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/unittests/format_pieces-selftests.c:72: format_piece ("%ps", ptr_arg, 0),
> gdb/unittests/format_pieces-selftests.c:74: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/unittests/format_pieces-selftests.c:74: format_piece ("%p]", ptr_arg, 0),
612a661
> gdb/valprint.c:2077: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/valprint.c:2077: fprintf_filtered (stream, " %p[<repeats %u times>%p]",
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
2019-10-02 1:56 New ARI warning Wed Oct 2 01:56:22 UTC 2019 GDB Administrator
@ 2019-10-02 2:50 ` Simon Marchi
2019-10-02 16:15 ` Tom Tromey
0 siblings, 1 reply; 10+ messages in thread
From: Simon Marchi @ 2019-10-02 2:50 UTC (permalink / raw)
To: GDB Administrator, gdb-patches
On 2019-10-01 9:56 p.m., GDB Administrator wrote:
> 4a5,6
>> gdb/ada-lang.c:3881: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/ada-lang.c:3881: printf_filtered (_(" at %p[<no source file available>%p]:%d\n"),
>> gdb/ada-lang.c:3885: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/ada-lang.c:3885: (_(" at %ps:%d\n"),
> 9a12,13
>> gdb/ada-valprint.c:241: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/ada-valprint.c:241: fprintf_filtered (stream, _(" %p[<repeats %u times>%p]"),
>> gdb/ada-valprint.c:532: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/ada-valprint.c:532: fprintf_filtered (stream, _(" %p[<repeats %u times>%p]"),
> 34a39,45
>> gdb/auto-load.c:494: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:494: warning (_("File \"%ps\" auto-loading has been declined by your "
>> gdb/auto-load.c:994: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:994:of file %ps."),
>> gdb/auto-load.c:1127: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1127: warning (_("Couldn't read %s section of %ps"),
>> gdb/auto-load.c:1358: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1358: printf_filtered (_("Local .gdbinit file \"%ps\" has been loaded.\n"),
>> gdb/auto-load.c:1362: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1362: printf_filtered (_("Local .gdbinit file \"%ps\" has not been loaded.\n"),
>> gdb/auto-load.c:1381: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1381:of file %ps.\n\
>> gdb/auto-load.c:1405: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1405:of file %ps.\n\
> 35a47,50
>> gdb/breakpoint.c:4915: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:4915: uiout->message ("\nWatchpoint %pF deleted because the program has "
>> gdb/breakpoint.c:6146: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:6146: uiout->message (" (%pF evals)",
>> gdb/breakpoint.c:6197: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:6197: uiout->message ("\tignore next %pF hits\n",
>> gdb/breakpoint.c:6661: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:6661: current_uiout->message (_("also set at pc %ps.\n"),
> 37a53,57
>> gdb/breakpoint.c:12078: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12078: printf_filtered (" at %ps",
>> gdb/breakpoint.c:12090: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12090: printf_filtered (": file %ps, line %d.",
>> gdb/breakpoint.c:12397: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12397: uiout->message ("Temporary breakpoint %pF, ",
>> gdb/breakpoint.c:12400: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12400: uiout->message ("Breakpoint %pF, ",
>> gdb/breakpoint.c:12717: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12717: uiout->message ("\tmarker id is %pF\n",
> 38a59,65
>> gdb/c-typeprint.c:1119: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1119: _("%p[<incomplete type>%p]\n"),
>> gdb/c-typeprint.c:1123: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1123: _("%p[<no data fields>%p]\n"),
>> gdb/c-typeprint.c:1282: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1282: _("%p[<undefined type>%p] %s;\n"),
>> gdb/c-typeprint.c:1629: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1629: _("%p[<incomplete type>%p]\n"),
>> gdb/c-typeprint.c:1633: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1633: _("%p[<no data fields>%p]\n"),
>> gdb/cli/cli-cmds.c:455: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/cli/cli-cmds.c:455: printf_unfiltered (_("Working directory %ps\n (canonically %ps).\n"),
>> gdb/cli/cli-cmds.c:460: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/cli/cli-cmds.c:460: printf_unfiltered (_("Working directory %ps.\n"),
> 51a79
>> gdb/cli/cli-logging.c:33: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/cli/cli-logging.c:33: fprintf_filtered (file, _("The current logfile is \"%ps\".\n"),
> 288a317
>> gdb/infrun.c:7661: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/infrun.c:7661: uiout->message ("[Inferior %s (%s) exited with code %pF]\n",
> 303a333,334
>> gdb/linux-thread-db.c:938: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/linux-thread-db.c:938: _("Using host libthread_db library \"%ps\".\n"),
>> gdb/linux-thread-db.c:1033: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/linux-thread-db.c:1033: " inferior, but got %ps."),
> 311a343
>> gdb/macrocmd.c:123: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/macrocmd.c:123: fprintf_filtered (stream, "%ps:%d\n",
> 389a422
>> gdb/p-lang.c:296: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/p-lang.c:296: fprintf_filtered (stream, " %p[<repeats %u times>%p]",
> 407a441,442
>> gdb/printcmd.c:2004: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/printcmd.c:2004: fprintf_filtered (gdb_stdout, _("%p[<error: %s>%p]\n"),
>> gdb/printcmd.c:2219: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/printcmd.c:2219: fprintf_filtered (stream, "%s%ps = ", n_spaces (2 * indent),
> 476a512
>> gdb/rust-lang.c:477: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/rust-lang.c:477: fprintf_filtered (stream, _("%s {%p[<No data fields>%p]}"),
> 499a536
>> gdb/stack.c:1528: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/stack.c:1528: (" (%ps:%d)",
> 507a545,547
>> gdb/symfile.c:1109: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symfile.c:1109: printf_filtered (_("Reading symbols from %ps...\n"),
>> gdb/symfile.c:1122: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symfile.c:1122: printf_filtered (_("Expanding full symbols from %ps...\n"),
>> gdb/symfile.c:1135: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symfile.c:1135: printf_filtered (_("(No debugging symbols found in %ps)\n"),
> 515a556,557
>> gdb/symtab.c:4751: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symtab.c:4751: printf_filtered (_("\nFile %ps:\n"),
>> gdb/symtab.c:4820: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symtab.c:4820: printf_filtered (_("%ps %ps\n"),
> 575a618
>> gdb/ui-out.c:644: code: long long: Do not use 'long long', instead use LONGEST
> gdb/ui-out.c:644: call_do_message (style, current_substring, va_arg (args, long long));
> 576a620,624
>> gdb/unittests/format_pieces-selftests.c:67: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:67: check ("Hello\\t \"%p[%pF%ps%*.*d%p]\"",
>> gdb/unittests/format_pieces-selftests.c:70: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:70: format_piece ("%p[", ptr_arg, 0),
>> gdb/unittests/format_pieces-selftests.c:71: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:71: format_piece ("%pF", ptr_arg, 0),
>> gdb/unittests/format_pieces-selftests.c:72: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:72: format_piece ("%ps", ptr_arg, 0),
>> gdb/unittests/format_pieces-selftests.c:74: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:74: format_piece ("%p]", ptr_arg, 0),
> 612a661
>> gdb/valprint.c:2077: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/valprint.c:2077: fprintf_filtered (stream, " %p[<repeats %u times>%p]",
>
Hmm, I think we can get rid of that %p rule (or improve it), otherwise we will have a lot of noise.
Simon
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
2019-10-02 2:50 ` Simon Marchi
@ 2019-10-02 16:15 ` Tom Tromey
2019-10-02 17:02 ` Eli Zaretskii
2019-10-02 17:30 ` Simon Marchi
0 siblings, 2 replies; 10+ messages in thread
From: Tom Tromey @ 2019-10-02 16:15 UTC (permalink / raw)
To: Simon Marchi; +Cc: GDB Administrator, gdb-patches
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>>> gdb/valprint.c:2077: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
>> gdb/valprint.c:2077: fprintf_filtered (stream, " %p[<repeats %u times>%p]",
>>
Simon> Hmm, I think we can get rid of that %p rule (or improve it),
Simon> otherwise we will have a lot of noise.
How's this?
Tom
commit ce98317860cdcdb19426ddee3509ccceea79c7b1
Author: Tom Tromey <tromey@adacore.com>
Date: Wed Oct 2 10:13:33 2019 -0600
Let ARI allow gdb %p printf extensions
As pointed out by Simon, this changes ARI to allow the gdb-specific %p
printf extensions.
gdb/ChangeLog
2019-10-02 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index cb450e28730..e79612696e6 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-10-02 Tom Tromey <tromey@adacore.com>
+
+ * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
+
2019-10-02 Tom Tromey <tromey@adacore.com>
* NEWS: Add $_ada_exception entry.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 4bd434c8fec..1556756a12c 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -353,7 +353,7 @@ Do not use printf(\"%p\"), instead use printf(\"%s\",paddr()) to dump a \
target address, or host_address_to_string() for a host address"
category["%p"] = ari_code
}
-/%p/ && !/%prec/ {
+/%p[^][sF]/ && !/%prec/ {
fail("%p")
}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
2019-10-02 16:15 ` Tom Tromey
@ 2019-10-02 17:02 ` Eli Zaretskii
2019-10-02 17:20 ` Tom Tromey
2019-10-02 17:30 ` Simon Marchi
1 sibling, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2019-10-02 17:02 UTC (permalink / raw)
To: Tom Tromey; +Cc: simark, gdbadmin, gdb-patches
> From: Tom Tromey <tromey@adacore.com>
> Cc: GDB Administrator <gdbadmin@sourceware.org>, gdb-patches@sourceware.org
> Date: Wed, 02 Oct 2019 10:15:05 -0600
>
> >>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> >>> gdb/valprint.c:2077: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> >> gdb/valprint.c:2077: fprintf_filtered (stream, " %p[<repeats %u times>%p]",
> >>
>
> Simon> Hmm, I think we can get rid of that %p rule (or improve it),
> Simon> otherwise we will have a lot of noise.
>
> How's this?
>
> Tom
>
> commit ce98317860cdcdb19426ddee3509ccceea79c7b1
> Author: Tom Tromey <tromey@adacore.com>
> Date: Wed Oct 2 10:13:33 2019 -0600
>
> Let ARI allow gdb %p printf extensions
>
> As pointed out by Simon, this changes ARI to allow the gdb-specific %p
> printf extensions.
But %p is really not quite portable. For starters, on some systems it
includes the 0x prefix, on others it doesn't.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
2019-10-02 16:15 ` Tom Tromey
2019-10-02 17:02 ` Eli Zaretskii
@ 2019-10-02 17:30 ` Simon Marchi
2019-10-02 17:35 ` Tom Tromey
1 sibling, 1 reply; 10+ messages in thread
From: Simon Marchi @ 2019-10-02 17:30 UTC (permalink / raw)
To: Tom Tromey; +Cc: GDB Administrator, gdb-patches
On 2019-10-02 12:15 p.m., Tom Tromey wrote:
> diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
> index 4bd434c8fec..1556756a12c 100755
> --- a/gdb/contrib/ari/gdb_ari.sh
> +++ b/gdb/contrib/ari/gdb_ari.sh
> @@ -353,7 +353,7 @@ Do not use printf(\"%p\"), instead use printf(\"%s\",paddr()) to dump a \
> target address, or host_address_to_string() for a host address"
> category["%p"] = ari_code
> }
> -/%p/ && !/%prec/ {
> +/%p[^][sF]/ && !/%prec/ {
> fail("%p")
> }
>
My mind is a bit confused by that regex: aren't the [^] and [sF] considered
as two successive character sets? If so, the caret character, which negates
the character set, applies to nothing.
Shouldn't there be some escaping involved? Or is the language smart enough
to know that because the first ] wouldn't end a valid character set, it means
it's not actually the end of the character set?
Simon
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
2019-10-02 17:30 ` Simon Marchi
@ 2019-10-02 17:35 ` Tom Tromey
2019-10-02 17:39 ` Simon Marchi
0 siblings, 1 reply; 10+ messages in thread
From: Tom Tromey @ 2019-10-02 17:35 UTC (permalink / raw)
To: Simon Marchi; +Cc: Tom Tromey, GDB Administrator, gdb-patches
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> +/%p[^][sF]/ && !/%prec/ {
Simon> My mind is a bit confused by that regex: aren't the [^] and [sF] considered
Simon> as two successive character sets? If so, the caret character, which negates
Simon> the character set, applies to nothing.
I believe that in most regexp syntax, a "]" doesn't need to be quoted in
a character class, provided it is either the first character (like
"[]...]") or comes immediately after the "^" (like "[^]...]").
The gawk manual mentions this, though it does also recommend using
backslash, so maybe I should just do that.
(info "(gawk) Bracket Expressions")
To include one of the characters '\', ']', '-', or '^' in a bracket
expression, put a '\' in front of it. For example:
[d\]]
matches either 'd' or ']'. Additionally, if you place ']' right after
the opening '[', the closing bracket is treated as one of the characters
to be matched.
Tom
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
2019-10-02 17:35 ` Tom Tromey
@ 2019-10-02 17:39 ` Simon Marchi
2019-10-02 17:45 ` Tom Tromey
0 siblings, 1 reply; 10+ messages in thread
From: Simon Marchi @ 2019-10-02 17:39 UTC (permalink / raw)
To: Tom Tromey; +Cc: GDB Administrator, gdb-patches
On 2019-10-02 1:35 p.m., Tom Tromey wrote:
> I believe that in most regexp syntax, a "]" doesn't need to be quoted in
> a character class, provided it is either the first character (like
> "[]...]") or comes immediately after the "^" (like "[^]...]").
>
> The gawk manual mentions this, though it does also recommend using
> backslash, so maybe I should just do that.
>
> (info "(gawk) Bracket Expressions")
>
> To include one of the characters '\', ']', '-', or '^' in a bracket
> expression, put a '\' in front of it. For example:
>
> [d\]]
>
> matches either 'd' or ']'. Additionally, if you place ']' right after
> the opening '[', the closing bracket is treated as one of the characters
> to be matched.
Well, as long as the regex does what it is meant to do, I am fine with it.
I just thought that it would be nice to have a small comment that explains
what it does, prevent using %p to print raw pointers, but allow the gdb
extensions.
Simon
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
2019-10-02 17:39 ` Simon Marchi
@ 2019-10-02 17:45 ` Tom Tromey
2019-10-08 17:16 ` Tom Tromey
0 siblings, 1 reply; 10+ messages in thread
From: Tom Tromey @ 2019-10-02 17:45 UTC (permalink / raw)
To: Simon Marchi; +Cc: Tom Tromey, gdb-patches
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> On 2019-10-02 1:35 p.m., Tom Tromey wrote:
>> I believe that in most regexp syntax, a "]" doesn't need to be quoted in
>> a character class, provided it is either the first character (like
>> "[]...]") or comes immediately after the "^" (like "[^]...]").
>>
>> The gawk manual mentions this, though it does also recommend using
>> backslash, so maybe I should just do that.
>>
>> (info "(gawk) Bracket Expressions")
>>
>> To include one of the characters '\', ']', '-', or '^' in a bracket
>> expression, put a '\' in front of it. For example:
>>
>> [d\]]
>>
>> matches either 'd' or ']'. Additionally, if you place ']' right after
>> the opening '[', the closing bracket is treated as one of the characters
>> to be matched.
Simon> Well, as long as the regex does what it is meant to do, I am fine with it.
Simon> I just thought that it would be nice to have a small comment that explains
Simon> what it does, prevent using %p to print raw pointers, but allow the gdb
Simon> extensions.
I went ahead and made both changes.
Tom
commit ab3347cd98e02bb676e85279bc64684b48f4c609
Author: Tom Tromey <tromey@adacore.com>
Date: Wed Oct 2 10:13:33 2019 -0600
Let ARI allow gdb %p printf extensions
As pointed out by Simon, this changes ARI to allow the gdb-specific %p
printf extensions.
gdb/ChangeLog
2019-10-02 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index cb450e28730..e79612696e6 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-10-02 Tom Tromey <tromey@adacore.com>
+
+ * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
+
2019-10-02 Tom Tromey <tromey@adacore.com>
* NEWS: Add $_ada_exception entry.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 4bd434c8fec..7202563f7a3 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -353,7 +353,8 @@ Do not use printf(\"%p\"), instead use printf(\"%s\",paddr()) to dump a \
target address, or host_address_to_string() for a host address"
category["%p"] = ari_code
}
-/%p/ && !/%prec/ {
+# Allow gdb %p extensions, but not other uses of %p.
+/%p[^[\]sF]/ && !/%prec/ {
fail("%p")
}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
2019-10-02 17:45 ` Tom Tromey
@ 2019-10-08 17:16 ` Tom Tromey
0 siblings, 0 replies; 10+ messages in thread
From: Tom Tromey @ 2019-10-08 17:16 UTC (permalink / raw)
To: Tom Tromey; +Cc: Simon Marchi, gdb-patches
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Simon> Well, as long as the regex does what it is meant to do, I am fine with it.
Simon> I just thought that it would be nice to have a small comment that explains
Simon> what it does, prevent using %p to print raw pointers, but allow the gdb
Simon> extensions.
Tom> I went ahead and made both changes.
I'm checking this in now.
Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-10-08 17:16 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 1:56 New ARI warning Wed Oct 2 01:56:22 UTC 2019 GDB Administrator
2019-10-02 2:50 ` Simon Marchi
2019-10-02 16:15 ` Tom Tromey
2019-10-02 17:02 ` Eli Zaretskii
2019-10-02 17:20 ` Tom Tromey
2019-10-02 17:30 ` Simon Marchi
2019-10-02 17:35 ` Tom Tromey
2019-10-02 17:39 ` Simon Marchi
2019-10-02 17:45 ` Tom Tromey
2019-10-08 17:16 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox