From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: simark@simark.ca, gdbadmin@sourceware.org, gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
Date: Wed, 02 Oct 2019 17:02:00 -0000 [thread overview]
Message-ID: <835zl784js.fsf@gnu.org> (raw)
In-Reply-To: <875zl7yvhy.fsf@tromey.com> (message from Tom Tromey on Wed, 02 Oct 2019 10:15:05 -0600)
> From: Tom Tromey <tromey@adacore.com>
> Cc: GDB Administrator <gdbadmin@sourceware.org>, gdb-patches@sourceware.org
> Date: Wed, 02 Oct 2019 10:15:05 -0600
>
> >>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> >>> gdb/valprint.c:2077: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> >> gdb/valprint.c:2077: fprintf_filtered (stream, " %p[<repeats %u times>%p]",
> >>
>
> Simon> Hmm, I think we can get rid of that %p rule (or improve it),
> Simon> otherwise we will have a lot of noise.
>
> How's this?
>
> Tom
>
> commit ce98317860cdcdb19426ddee3509ccceea79c7b1
> Author: Tom Tromey <tromey@adacore.com>
> Date: Wed Oct 2 10:13:33 2019 -0600
>
> Let ARI allow gdb %p printf extensions
>
> As pointed out by Simon, this changes ARI to allow the gdb-specific %p
> printf extensions.
But %p is really not quite portable. For starters, on some systems it
includes the 0x prefix, on others it doesn't.
next prev parent reply other threads:[~2019-10-02 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 1:56 GDB Administrator
2019-10-02 2:50 ` Simon Marchi
2019-10-02 16:15 ` Tom Tromey
2019-10-02 17:02 ` Eli Zaretskii [this message]
2019-10-02 17:20 ` Tom Tromey
2019-10-02 17:30 ` Simon Marchi
2019-10-02 17:35 ` Tom Tromey
2019-10-02 17:39 ` Simon Marchi
2019-10-02 17:45 ` Tom Tromey
2019-10-08 17:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835zl784js.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gdbadmin@sourceware.org \
--cc=simark@simark.ca \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox