From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: GDB Administrator <gdbadmin@sourceware.org>, gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
Date: Wed, 02 Oct 2019 17:30:00 -0000 [thread overview]
Message-ID: <dc40ec1b-5702-99ac-7cef-7322086255bf@simark.ca> (raw)
In-Reply-To: <875zl7yvhy.fsf@tromey.com>
On 2019-10-02 12:15 p.m., Tom Tromey wrote:
> diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
> index 4bd434c8fec..1556756a12c 100755
> --- a/gdb/contrib/ari/gdb_ari.sh
> +++ b/gdb/contrib/ari/gdb_ari.sh
> @@ -353,7 +353,7 @@ Do not use printf(\"%p\"), instead use printf(\"%s\",paddr()) to dump a \
> target address, or host_address_to_string() for a host address"
> category["%p"] = ari_code
> }
> -/%p/ && !/%prec/ {
> +/%p[^][sF]/ && !/%prec/ {
> fail("%p")
> }
>
My mind is a bit confused by that regex: aren't the [^] and [sF] considered
as two successive character sets? If so, the caret character, which negates
the character set, applies to nothing.
Shouldn't there be some escaping involved? Or is the language smart enough
to know that because the first ] wouldn't end a valid character set, it means
it's not actually the end of the character set?
Simon
next prev parent reply other threads:[~2019-10-02 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 1:56 GDB Administrator
2019-10-02 2:50 ` Simon Marchi
2019-10-02 16:15 ` Tom Tromey
2019-10-02 17:02 ` Eli Zaretskii
2019-10-02 17:20 ` Tom Tromey
2019-10-02 17:30 ` Simon Marchi [this message]
2019-10-02 17:35 ` Tom Tromey
2019-10-02 17:39 ` Simon Marchi
2019-10-02 17:45 ` Tom Tromey
2019-10-08 17:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc40ec1b-5702-99ac-7cef-7322086255bf@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=gdbadmin@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox