From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159224-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16747 invoked by alias); 2 Oct 2019 02:50:11 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16739 invoked by uid 89); 2 Oct 2019 02:50:11 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=Administrator
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Oct 2019 02:50:09 +0000
Received: from [10.0.0.11] (unknown [192.222.164.54])	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)	 key-exchange X25519 server-signature RSA-PSS (2048 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 7D6C61E093;	Tue,  1 Oct 2019 22:50:07 -0400 (EDT)
Subject: Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019
To: GDB Administrator <gdbadmin@sourceware.org>, gdb-patches@sourceware.org
References: <20191002015622.GA57488@sourceware.org>
From: Simon Marchi <simark@simark.ca>
Message-ID: <e5f64ebd-e34a-cc1d-32ff-81d65d57833c@simark.ca>
Date: Wed, 02 Oct 2019 02:50:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191002015622.GA57488@sourceware.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-10/txt/msg00056.txt.bz2

On 2019-10-01 9:56 p.m., GDB Administrator wrote:
> 4a5,6
>> gdb/ada-lang.c:3881: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/ada-lang.c:3881:	    printf_filtered (_(" at %p[<no source file available>%p]:%d\n"),
>> gdb/ada-lang.c:3885: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/ada-lang.c:3885:	      (_(" at %ps:%d\n"),
> 9a12,13
>> gdb/ada-valprint.c:241: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/ada-valprint.c:241:	  fprintf_filtered (stream, _(" %p[<repeats %u times>%p]"),
>> gdb/ada-valprint.c:532: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/ada-valprint.c:532:	  fprintf_filtered (stream, _(" %p[<repeats %u times>%p]"),
> 34a39,45
>> gdb/auto-load.c:494: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:494:  warning (_("File \"%ps\" auto-loading has been declined by your "
>> gdb/auto-load.c:994: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:994:of file %ps."),
>> gdb/auto-load.c:1127: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1127:    warning (_("Couldn't read %s section of %ps"),
>> gdb/auto-load.c:1358: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1358:    printf_filtered (_("Local .gdbinit file \"%ps\" has been loaded.\n"),
>> gdb/auto-load.c:1362: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1362:    printf_filtered (_("Local .gdbinit file \"%ps\" has not been loaded.\n"),
>> gdb/auto-load.c:1381: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1381:of file %ps.\n\
>> gdb/auto-load.c:1405: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/auto-load.c:1405:of file %ps.\n\
> 35a47,50
>> gdb/breakpoint.c:4915: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:4915:	  uiout->message ("\nWatchpoint %pF deleted because the program has "
>> gdb/breakpoint.c:6146: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:6146:	  uiout->message (" (%pF evals)",
>> gdb/breakpoint.c:6197: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:6197:      uiout->message ("\tignore next %pF hits\n",
>> gdb/breakpoint.c:6661: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:6661:      current_uiout->message (_("also set at pc %ps.\n"),
> 37a53,57
>> gdb/breakpoint.c:12078: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12078:	printf_filtered (" at %ps",
>> gdb/breakpoint.c:12090: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12090:	      printf_filtered (": file %ps, line %d.",
>> gdb/breakpoint.c:12397: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12397:    uiout->message ("Temporary breakpoint %pF, ",
>> gdb/breakpoint.c:12400: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12400:    uiout->message ("Breakpoint %pF, ",
>> gdb/breakpoint.c:12717: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/breakpoint.c:12717:      uiout->message ("\tmarker id is %pF\n",
> 38a59,65
>> gdb/c-typeprint.c:1119: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1119:			       _("%p[<incomplete type>%p]\n"),
>> gdb/c-typeprint.c:1123: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1123:			       _("%p[<no data fields>%p]\n"),
>> gdb/c-typeprint.c:1282: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1282:				    _("%p[<undefined type>%p] %s;\n"),
>> gdb/c-typeprint.c:1629: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1629:				     _("%p[<incomplete type>%p]\n"),
>> gdb/c-typeprint.c:1633: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/c-typeprint.c:1633:				     _("%p[<no data fields>%p]\n"),
>> gdb/cli/cli-cmds.c:455: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/cli/cli-cmds.c:455:    printf_unfiltered (_("Working directory %ps\n (canonically %ps).\n"),
>> gdb/cli/cli-cmds.c:460: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/cli/cli-cmds.c:460:    printf_unfiltered (_("Working directory %ps.\n"),
> 51a79
>> gdb/cli/cli-logging.c:33: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/cli/cli-logging.c:33:  fprintf_filtered (file, _("The current logfile is \"%ps\".\n"),
> 288a317
>> gdb/infrun.c:7661: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/infrun.c:7661:      uiout->message ("[Inferior %s (%s) exited with code %pF]\n",
> 303a333,334
>> gdb/linux-thread-db.c:938: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/linux-thread-db.c:938:			  _("Using host libthread_db library \"%ps\".\n"),
>> gdb/linux-thread-db.c:1033: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/linux-thread-db.c:1033:		 " inferior, but got %ps."),
> 311a343
>> gdb/macrocmd.c:123: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/macrocmd.c:123:  fprintf_filtered (stream, "%ps:%d\n",
> 389a422
>> gdb/p-lang.c:296: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/p-lang.c:296:	  fprintf_filtered (stream, " %p[<repeats %u times>%p]",
> 407a441,442
>> gdb/printcmd.c:2004: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/printcmd.c:2004:	  fprintf_filtered (gdb_stdout, _("%p[<error: %s>%p]\n"),
>> gdb/printcmd.c:2219: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/printcmd.c:2219:  fprintf_filtered (stream, "%s%ps = ", n_spaces (2 * indent),
> 476a512
>> gdb/rust-lang.c:477: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/rust-lang.c:477:      fprintf_filtered (stream, _("%s {%p[<No data fields>%p]}"),
> 499a536
>> gdb/stack.c:1528: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/stack.c:1528:      (" (%ps:%d)",
> 507a545,547
>> gdb/symfile.c:1109: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symfile.c:1109:	printf_filtered (_("Reading symbols from %ps...\n"),
>> gdb/symfile.c:1122: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symfile.c:1122:	printf_filtered (_("Expanding full symbols from %ps...\n"),
>> gdb/symfile.c:1135: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symfile.c:1135:    printf_filtered (_("(No debugging symbols found in %ps)\n"),
> 515a556,557
>> gdb/symtab.c:4751: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symtab.c:4751:	  printf_filtered (_("\nFile %ps:\n"),
>> gdb/symtab.c:4820: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/symtab.c:4820:  printf_filtered (_("%ps  %ps\n"),
> 575a618
>> gdb/ui-out.c:644: code: long long: Do not use 'long long', instead use LONGEST
> gdb/ui-out.c:644:	  call_do_message (style, current_substring, va_arg (args, long long));
> 576a620,624
>> gdb/unittests/format_pieces-selftests.c:67: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:67:  check ("Hello\\t \"%p[%pF%ps%*.*d%p]\"",
>> gdb/unittests/format_pieces-selftests.c:70: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:70:      format_piece ("%p[", ptr_arg, 0),
>> gdb/unittests/format_pieces-selftests.c:71: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:71:      format_piece ("%pF", ptr_arg, 0),
>> gdb/unittests/format_pieces-selftests.c:72: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:72:      format_piece ("%ps", ptr_arg, 0),
>> gdb/unittests/format_pieces-selftests.c:74: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/unittests/format_pieces-selftests.c:74:      format_piece ("%p]", ptr_arg, 0),
> 612a661
>> gdb/valprint.c:2077: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> gdb/valprint.c:2077:	  fprintf_filtered (stream, " %p[<repeats %u times>%p]",
> 

Hmm, I think we can get rid of that %p rule (or improve it), otherwise we will have a lot of noise.

Simon