From: Luis Machado <lgustavo@codesourcery.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/8] Fixup testcases outputting own name as a test name
Date: Fri, 25 Nov 2016 18:26:00 -0000 [thread overview]
Message-ID: <81665d33-cfb5-8af5-342e-a743d54bb80a@codesourcery.com> (raw)
In-Reply-To: <eb9b3920b0d6d639ec59e4eea26bcdf5@polymtl.ca>
On 11/25/2016 12:02 PM, Simon Marchi wrote:
> On 2016-11-25 12:55, Pedro Alves wrote:
>> Or just not pass anything about the target file?
>> "failed to compile" works just as well, IMO. If you need more detail,
>> it's in the gdb.log.
>
> Agreed, I think that's even better. I was first thinking it would be
> useful to have the dest file, in the cases where the same source file is
> compiled multiple times to multiple destinations. But you're right that
> if you want details, you'll go look at gdb.log. It's enough for the
> test name to give a rough idea of what failed.
Great. I'll adjust things.
Should i get the existing tests that already output srcfile paths on
compilation failures fixed up and standardized with this patch as well
or with a separate one?
I'd hate to fix some of these up and leave other offenders lying around.
next prev parent reply other threads:[~2016-11-25 18:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 17:09 [PATCH 0/8] Fix gdb's testsuite test names Luis Machado
2016-11-25 17:09 ` [PATCH 3/8] Fix test names starting with uppercase using gdb_test on a single line Luis Machado
2016-11-25 17:09 ` [PATCH 1/8] Fixup testcases outputting own name as a test name Luis Machado
2016-11-25 17:28 ` Pedro Alves
2016-11-25 17:37 ` Luis Machado
2016-11-25 17:48 ` Simon Marchi
2016-11-25 17:53 ` Luis Machado
2016-11-25 17:55 ` Pedro Alves
2016-11-25 18:02 ` Simon Marchi
2016-11-25 18:26 ` Luis Machado [this message]
2016-11-25 18:39 ` Pedro Alves
2016-11-25 17:09 ` [PATCH 4/8] Fix test names starting with uppercase using gdb_test_no_output Luis Machado
2016-11-25 17:09 ` [PATCH 7/8] Fix test names starting with uppercase using multi-line gdb_test_no_output Luis Machado
2016-11-25 17:09 ` [PATCH 6/8] Fix test names starting with uppercase using multi-line gdb_test/mi_gdb_test Luis Machado
2016-11-25 17:09 ` [PATCH 5/8] Fix test names starting with uppercase using gdb_test_multiple Luis Machado
2016-11-25 17:09 ` [PATCH 8/8] Fix test names starting with uppercase using multi-line gdb_test_multiple Luis Machado
2016-11-25 17:10 ` [PATCH 2/8] Fix test names starting with uppercase output by basic functions Luis Machado
2016-11-25 18:00 ` Pedro Alves
2016-11-25 17:31 ` [PATCH 0/8] Fix gdb's testsuite test names Simon Marchi
2016-11-25 17:35 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81665d33-cfb5-8af5-342e-a743d54bb80a@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox