[PATCH 7/8] Fix test names starting with uppercase using multi-line gdb_test_no_output

Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed

From: Luis Machado <lgustavo@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 7/8] Fix test names starting with uppercase using multi-line gdb_test_no_output
Date: Fri, 25 Nov 2016 17:09:00 -0000	[thread overview]
Message-ID: <1480093744-13771-8-git-send-email-lgustavo@codesourcery.com> (raw)
In-Reply-To: <1480093744-13771-1-git-send-email-lgustavo@codesourcery.com>

This fixes offender testcases that have test names starting with uppercase
when using gdb_test_no_output in a multi-line construct.

gdb/testsuite/ChangeLog
2016-11-25  Luis Machado  <lgustavo@codesourcery.com>

	Fix test names starting with uppercase throughout the files.

	* gdb/testsuite/gdb.ada/assign_1.exp
	* gdb/testsuite/gdb.ada/boolean_expr.exp
	* gdb/testsuite/gdb.base/arrayidx.exp
	* gdb/testsuite/gdb.base/del.exp
	* gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
	* gdb/testsuite/gdb.base/testenv.exp
	* gdb/testsuite/gdb.compile/compile.exp
	* gdb/testsuite/gdb.python/py-framefilter-invalidarg.exp
	* gdb/testsuite/gdb.python/py-framefilter.exp
---
 gdb/testsuite/gdb.ada/assign_1.exp                     | 2 +-
 gdb/testsuite/gdb.ada/boolean_expr.exp                 | 2 +-
 gdb/testsuite/gdb.base/arrayidx.exp                    | 4 ++--
 gdb/testsuite/gdb.base/del.exp                         | 2 +-
 gdb/testsuite/gdb.base/gcore-buffer-overflow.exp       | 2 +-
 gdb/testsuite/gdb.base/testenv.exp                     | 8 ++++----
 gdb/testsuite/gdb.compile/compile.exp                  | 6 +++---
 gdb/testsuite/gdb.python/py-framefilter-invalidarg.exp | 4 ++--
 gdb/testsuite/gdb.python/py-framefilter.exp            | 6 +++---
 9 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/gdb/testsuite/gdb.ada/assign_1.exp b/gdb/testsuite/gdb.ada/assign_1.exp
index 074ec42..2df028c 100644
--- a/gdb/testsuite/gdb.ada/assign_1.exp
+++ b/gdb/testsuite/gdb.ada/assign_1.exp
@@ -22,7 +22,7 @@ gdb_reinitialize_dir $srcdir/$subdir
 # Force the language to Ada, as this will not happen automatically
 # in this case (no test program).
 gdb_test_no_output "set lang ada" \
-         "Changing the language to ada"
+         "changing the language to ada"
 
 gdb_test "print \$xxx := 1" \
          "= 1" \
diff --git a/gdb/testsuite/gdb.ada/boolean_expr.exp b/gdb/testsuite/gdb.ada/boolean_expr.exp
index 4b8d1d8..8b8c57c 100644
--- a/gdb/testsuite/gdb.ada/boolean_expr.exp
+++ b/gdb/testsuite/gdb.ada/boolean_expr.exp
@@ -25,7 +25,7 @@ set any_addr "0x\[0-9a-zA-Z\]+"
 # Force the language to Ada, as this will not happen automatically
 # in this case (no test program).
 gdb_test_no_output "set lang ada" \
-         "Changing the language to ada"
+         "changing the language to ada"
 
 gdb_test "print 1 = 2" \
          "= false" \
diff --git a/gdb/testsuite/gdb.base/arrayidx.exp b/gdb/testsuite/gdb.base/arrayidx.exp
index bfd186b..c7c707a 100644
--- a/gdb/testsuite/gdb.base/arrayidx.exp
+++ b/gdb/testsuite/gdb.base/arrayidx.exp
@@ -34,7 +34,7 @@ if ![runto_main] then {
 # First, print the array without the indexes
 
 gdb_test_no_output "set print array-indexes off" \
-         "Set print array-indexes to off"
+         "set print array-indexes to off"
 
 gdb_test "print array" \
          "\\{1, 2, 3, 4\\}" \
@@ -43,7 +43,7 @@ gdb_test "print array" \
 # Second, print the same array with the indexes
 
 gdb_test_no_output "set print array-indexes on" \
-         "Set print array-indexes to on"
+         "set print array-indexes to on"
 
 gdb_test "print array" \
          "\\{\\\[0\\\] = 1, \\\[1\\\] = 2, \\\[2\\\] = 3, \\\[3\\\] = 4\\}" \
diff --git a/gdb/testsuite/gdb.base/del.exp b/gdb/testsuite/gdb.base/del.exp
index e7a8c2d..2d7e920 100644
--- a/gdb/testsuite/gdb.base/del.exp
+++ b/gdb/testsuite/gdb.base/del.exp
@@ -33,7 +33,7 @@ proc test_delete_alias { alias } {
     # First of all, remove all previous breakpoints if there were any,
     # and then verify that we do not have any breakpoint lying around.
     gdb_test_no_output "delete" \
-             "Remove all breakpoints ($alias)"
+             "remove all breakpoints ($alias)"
 
     gdb_test "info break" \
              "No breakpoints or watchpoints." \
diff --git a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
index 72f03ac..92df25f 100644
--- a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
+++ b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
@@ -32,7 +32,7 @@ if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
 clean_restart ${binfile}
 
 gdb_test_no_output "set args ${pattern}"	\
-    "Set buffer exceeding arguments"
+    "set buffer exceeding arguments"
 
 if { ! [ runto_main ] } then {
     untested gcore-buffer-overflow.exp
diff --git a/gdb/testsuite/gdb.base/testenv.exp b/gdb/testsuite/gdb.base/testenv.exp
index 27cfe04..9d03f91 100644
--- a/gdb/testsuite/gdb.base/testenv.exp
+++ b/gdb/testsuite/gdb.base/testenv.exp
@@ -52,7 +52,7 @@ gdb_test "continue" \
   "test no TEST_GDB var"
 
 gdb_test_no_output "set env TEST_GDB_VAR1 test1" \
-  "Set TEST_GDB_VAR1"
+  "set TEST_GDB_VAR1"
 
 runto_main
 gdb_breakpoint  $bp_line
@@ -63,7 +63,7 @@ gdb_test "continue" \
   "test with one TEST_GDB var"
 
 gdb_test_no_output "set env TEST_GDB_VAR2 test2" \
-  "Set TEST_GDB_VAR2"
+  "set TEST_GDB_VAR2"
 
 runto_main
 gdb_breakpoint  $bp_line
@@ -74,7 +74,7 @@ gdb_test "continue"  \
   "test with two TEST_GDB var"
 
 gdb_test_no_output "unset env TEST_GDB_VAR1" \
-  "Unset TEST_GDB_VAR1"
+  "unset TEST_GDB_VAR1"
 
 runto_main
 gdb_breakpoint  $bp_line
@@ -106,7 +106,7 @@ gdb_test "continue" \
   "test with TEST_GDB_GLOBAL"
 
 gdb_test_no_output "unset env TEST_GDB_GLOBAL" \
-  "Unset TEST_GDB_GLOBAL"
+  "unset TEST_GDB_GLOBAL"
 
 runto_main
 gdb_breakpoint  $bp_line
diff --git a/gdb/testsuite/gdb.compile/compile.exp b/gdb/testsuite/gdb.compile/compile.exp
index cec44d8..93d5873 100644
--- a/gdb/testsuite/gdb.compile/compile.exp
+++ b/gdb/testsuite/gdb.compile/compile.exp
@@ -66,16 +66,16 @@ if {[skip_compile_feature_tests]} {
 #
 
 gdb_test_no_output "compile -- f = 10" \
-    "Test abbreviations and code delimiter"
+    "test abbreviations and code delimiter"
 
 gdb_test "compile f = 10;" ".*= 10;: No such file.*" \
     "Test abbreviations and code collision"
 
 gdb_test_no_output "compile -r -- void _gdb_expr(){int i = 5;}" \
-    "Test delimiter with -r"
+    "test delimiter with -r"
 
 gdb_test_no_output "compile -raw -- void _gdb_expr(){int i = 5;}" \
-    "Test delimiter with -raw"
+    "test delimiter with -raw"
 
 gdb_test "compile -- -r  void _gdb_expr(){int i = 5;}" \
     ".* error: 'r' undeclared \\(first use in this function\\).*" \
diff --git a/gdb/testsuite/gdb.python/py-framefilter-invalidarg.exp b/gdb/testsuite/gdb.python/py-framefilter-invalidarg.exp
index d072adf..50fbc5b 100644
--- a/gdb/testsuite/gdb.python/py-framefilter-invalidarg.exp
+++ b/gdb/testsuite/gdb.python/py-framefilter-invalidarg.exp
@@ -56,12 +56,12 @@ if ![runto_main] then {
     return
 }
 gdb_test_no_output "set python print-stack full" \
-    "Set python print-stack to full"
+    "set python print-stack to full"
 
 # Load global frame-filters
 set remote_python_file [gdb_remote_download host \
 			    ${srcdir}/${subdir}/${testfile}.py]
 gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" \
-    "Load python file"
+    "load python file"
 
 gdb_test "bt" " in niam \\(argc=<error reading variable: dwarf expression stack underflow>, argv=0x\[0-9a-f\]+\\) at py-framefilter-invalidarg.c:\[0-9\]+" "bt full with filters"
diff --git a/gdb/testsuite/gdb.python/py-framefilter.exp b/gdb/testsuite/gdb.python/py-framefilter.exp
index 7abf3a9..0bfecdf 100644
--- a/gdb/testsuite/gdb.python/py-framefilter.exp
+++ b/gdb/testsuite/gdb.python/py-framefilter.exp
@@ -58,13 +58,13 @@ if ![runto_main] then {
     return
 }
 gdb_test_no_output "set python print-stack full" \
-    "Set python print-stack to full"
+    "set python print-stack to full"
 
 # Load global frame-filters
 set remote_python_file [gdb_remote_download host \
 			    ${srcdir}/${subdir}/${testfile}.py]
 gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" \
-    "Load python file"
+    "load python file"
 
 gdb_breakpoint [gdb_get_line_number "Backtrace end breakpoint"]
 gdb_breakpoint [gdb_get_line_number "Inner test breakpoint"]
@@ -254,7 +254,7 @@ gdb_test_no_output "set python print-stack full" \
 set remote_python_file [gdb_remote_download host \
 			    ${srcdir}/${subdir}/${testfile}.py]
 gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" \
-    "Load python file for no debuginfo tests"
+    "load python file for no debuginfo tests"
 
 # Disable Reverse
 gdb_test_no_output "disable frame-filter global Reverse" \
-- 
2.7.4

next prev parent reply	other threads:[~2016-11-25 17:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25 17:09 [PATCH 0/8] Fix gdb's testsuite test names Luis Machado
2016-11-25 17:09 ` [PATCH 3/8] Fix test names starting with uppercase using gdb_test on a single line Luis Machado
2016-11-25 17:09 ` [PATCH 1/8] Fixup testcases outputting own name as a test name Luis Machado
2016-11-25 17:28   ` Pedro Alves
2016-11-25 17:37     ` Luis Machado
2016-11-25 17:48       ` Simon Marchi
2016-11-25 17:53         ` Luis Machado
2016-11-25 17:55         ` Pedro Alves
2016-11-25 18:02           ` Simon Marchi
2016-11-25 18:26             ` Luis Machado
2016-11-25 18:39               ` Pedro Alves
2016-11-25 17:09 ` [PATCH 4/8] Fix test names starting with uppercase using gdb_test_no_output Luis Machado
2016-11-25 17:09 ` Luis Machado [this message]
2016-11-25 17:09 ` [PATCH 6/8] Fix test names starting with uppercase using multi-line gdb_test/mi_gdb_test Luis Machado
2016-11-25 17:09 ` [PATCH 5/8] Fix test names starting with uppercase using gdb_test_multiple Luis Machado
2016-11-25 17:09 ` [PATCH 8/8] Fix test names starting with uppercase using multi-line gdb_test_multiple Luis Machado
2016-11-25 17:10 ` [PATCH 2/8] Fix test names starting with uppercase output by basic functions Luis Machado
2016-11-25 18:00   ` Pedro Alves
2016-11-25 17:31 ` [PATCH 0/8] Fix gdb's testsuite test names Simon Marchi
2016-11-25 17:35   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480093744-13771-8-git-send-email-lgustavo@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox