From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/8] Fixup testcases outputting own name as a test name
Date: Fri, 25 Nov 2016 17:28:00 -0000 [thread overview]
Message-ID: <a7857dc7-710e-dd47-f931-e5ba37392311@redhat.com> (raw)
In-Reply-To: <1480093744-13771-2-git-send-email-lgustavo@codesourcery.com>
On 11/25/2016 05:08 PM, Luis Machado wrote:
> diff --git a/gdb/testsuite/gdb.base/charset.exp b/gdb/testsuite/gdb.base/charset.exp
> index 44d5502..eb9b37a 100644
> --- a/gdb/testsuite/gdb.base/charset.exp
> +++ b/gdb/testsuite/gdb.base/charset.exp
> @@ -146,7 +146,7 @@ gdb_expect {
> # sets: "auto" and the default. In this situation, this set of tests
> # is pointless.
> if {[llength [array names charsets]] < 3} {
> - untested charset.exp
> + untested "less than 3 charsets"
"fewer than"
/me runs.
> + untested "couldn't compile ${srcfile} to ${binfile}"
I think all these references to $binfile will put the full file
path on gdb.sum? I think you want $testfile instead.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-11-25 17:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 17:09 [PATCH 0/8] Fix gdb's testsuite test names Luis Machado
2016-11-25 17:09 ` [PATCH 7/8] Fix test names starting with uppercase using multi-line gdb_test_no_output Luis Machado
2016-11-25 17:09 ` [PATCH 1/8] Fixup testcases outputting own name as a test name Luis Machado
2016-11-25 17:28 ` Pedro Alves [this message]
2016-11-25 17:37 ` Luis Machado
2016-11-25 17:48 ` Simon Marchi
2016-11-25 17:53 ` Luis Machado
2016-11-25 17:55 ` Pedro Alves
2016-11-25 18:02 ` Simon Marchi
2016-11-25 18:26 ` Luis Machado
2016-11-25 18:39 ` Pedro Alves
2016-11-25 17:09 ` [PATCH 3/8] Fix test names starting with uppercase using gdb_test on a single line Luis Machado
2016-11-25 17:09 ` [PATCH 4/8] Fix test names starting with uppercase using gdb_test_no_output Luis Machado
2016-11-25 17:09 ` [PATCH 6/8] Fix test names starting with uppercase using multi-line gdb_test/mi_gdb_test Luis Machado
2016-11-25 17:09 ` [PATCH 5/8] Fix test names starting with uppercase using gdb_test_multiple Luis Machado
2016-11-25 17:09 ` [PATCH 8/8] Fix test names starting with uppercase using multi-line gdb_test_multiple Luis Machado
2016-11-25 17:10 ` [PATCH 2/8] Fix test names starting with uppercase output by basic functions Luis Machado
2016-11-25 18:00 ` Pedro Alves
2016-11-25 17:31 ` [PATCH 0/8] Fix gdb's testsuite test names Simon Marchi
2016-11-25 17:35 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7857dc7-710e-dd47-f931-e5ba37392311@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox