Re: [PATCH 1/8] Fixup testcases outputting own name as a test name

[Luis Machado <lgustavo@codesourcery.com>]

On 11/25/2016 11:28 AM, Pedro Alves wrote:
> On 11/25/2016 05:08 PM, Luis Machado wrote:
>
>> diff --git a/gdb/testsuite/gdb.base/charset.exp b/gdb/testsuite/gdb.base/charset.exp
>> index 44d5502..eb9b37a 100644
>> --- a/gdb/testsuite/gdb.base/charset.exp
>> +++ b/gdb/testsuite/gdb.base/charset.exp
>> @@ -146,7 +146,7 @@ gdb_expect {
>>  # sets: "auto" and the default.  In this situation, this set of tests
>>  # is pointless.
>>  if {[llength [array names charsets]] < 3} {
>> -    untested charset.exp
>> +    untested "less than 3 charsets"
>
> "fewer than"
>
> /me runs.
>

:-)

>> +    untested "couldn't compile ${srcfile} to ${binfile}"
>
> I think all these references to $binfile will put the full file
> path on gdb.sum?  I think you want $testfile instead.
>
> Thanks,
> Pedro Alves
>

They will, which may make it easier to just build the files by hand with 
the output from the log file. But it has the potential to be a big path.

I'm fine with either approach.