From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135285-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 97407 invoked by alias); 25 Nov 2016 17:37:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 97332 invoked by uid 89); 25 Nov 2016 17:37:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 17:37:27 +0000
Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203])	by relay1.mentorg.com with esmtp 	id 1cAKRB-00078h-Hs from Luis_Gustavo@mentor.com ; Fri, 25 Nov 2016 09:37:25 -0800
Received: from [172.30.6.103] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 25 Nov 2016 09:37:22 -0800
Reply-To: Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [PATCH 1/8] Fixup testcases outputting own name as a test name
References: <1480093744-13771-1-git-send-email-lgustavo@codesourcery.com> <1480093744-13771-2-git-send-email-lgustavo@codesourcery.com> <a7857dc7-710e-dd47-f931-e5ba37392311@redhat.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
From: Luis Machado <lgustavo@codesourcery.com>
Message-ID: <2b7ca30d-f563-dd11-7934-60505d261a24@codesourcery.com>
Date: Fri, 25 Nov 2016 17:37:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <a7857dc7-710e-dd47-f931-e5ba37392311@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203)
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg00825.txt.bz2

On 11/25/2016 11:28 AM, Pedro Alves wrote:
> On 11/25/2016 05:08 PM, Luis Machado wrote:
>
>> diff --git a/gdb/testsuite/gdb.base/charset.exp b/gdb/testsuite/gdb.base/charset.exp
>> index 44d5502..eb9b37a 100644
>> --- a/gdb/testsuite/gdb.base/charset.exp
>> +++ b/gdb/testsuite/gdb.base/charset.exp
>> @@ -146,7 +146,7 @@ gdb_expect {
>>  # sets: "auto" and the default.  In this situation, this set of tests
>>  # is pointless.
>>  if {[llength [array names charsets]] < 3} {
>> -    untested charset.exp
>> +    untested "less than 3 charsets"
>
> "fewer than"
>
> /me runs.
>

:-)

>> +    untested "couldn't compile ${srcfile} to ${binfile}"
>
> I think all these references to $binfile will put the full file
> path on gdb.sum?  I think you want $testfile instead.
>
> Thanks,
> Pedro Alves
>

They will, which may make it easier to just build the files by hand with 
the output from the log file. But it has the potential to be a big path.

I'm fine with either approach.