From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14856 invoked by alias); 25 Nov 2016 18:26:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14838 invoked by uid 89); 25 Nov 2016 18:26:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=destinations X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 18:26:42 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cALCr-0000uS-Di from Luis_Gustavo@mentor.com ; Fri, 25 Nov 2016 10:26:41 -0800 Received: from [172.30.6.103] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 25 Nov 2016 10:26:38 -0800 Reply-To: Luis Machado Subject: Re: [PATCH 1/8] Fixup testcases outputting own name as a test name References: <1480093744-13771-1-git-send-email-lgustavo@codesourcery.com> <1480093744-13771-2-git-send-email-lgustavo@codesourcery.com> <2b7ca30d-f563-dd11-7934-60505d261a24@codesourcery.com> <5cfc70b2ea19762c664d61f752c02a41@polymtl.ca> <0b33f003-4d18-05dd-c74b-96d2026fcf2f@redhat.com> To: Simon Marchi , Pedro Alves CC: From: Luis Machado Message-ID: <81665d33-cfb5-8af5-342e-a743d54bb80a@codesourcery.com> Date: Fri, 25 Nov 2016 18:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00832.txt.bz2 On 11/25/2016 12:02 PM, Simon Marchi wrote: > On 2016-11-25 12:55, Pedro Alves wrote: >> Or just not pass anything about the target file? >> "failed to compile" works just as well, IMO. If you need more detail, >> it's in the gdb.log. > > Agreed, I think that's even better. I was first thinking it would be > useful to have the dest file, in the cases where the same source file is > compiled multiple times to multiple destinations. But you're right that > if you want details, you'll go look at gdb.log. It's enough for the > test name to give a rough idea of what failed. Great. I'll adjust things. Should i get the existing tests that already output srcfile paths on compilation failures fixed up and standardized with this patch as well or with a separate one? I'd hate to fix some of these up and leave other offenders lying around.