From: Simon Marchi <simark@simark.ca>
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, btrace: fix wrong #endif comments
Date: Mon, 4 May 2026 10:44:10 -0400 [thread overview]
Message-ID: <5b8466c0-1b81-4e4d-86f9-71a8276ad57e@simark.ca> (raw)
In-Reply-To: <20260504071636.1571615-1-markus.t.metzger@intel.com>
On 5/4/26 3:16 AM, Markus Metzger wrote:
> ---
> gdb/btrace.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gdb/btrace.c b/gdb/btrace.c
> index f9c6f0e5b6a..ef152c531fb 100644
> --- a/gdb/btrace.c
> +++ b/gdb/btrace.c
> @@ -1283,7 +1283,7 @@ decode_interrupt_vector (const uint8_t vector)
>
> return nullptr;
> }
> -#endif /* defined (LIBIPT_VERSION >= 0x201) */
> +#endif /* (LIBIPT_VERSION >= 0x201) */
>
> /* Handle instruction decode events (libipt-v2). */
>
> @@ -1596,7 +1596,7 @@ handle_pt_insn_events (struct btrace_thread_info *btinfo,
> handle_pt_aux_insn (btinfo, aux_string, pc);
> break;
> }
> -#endif /* defined (LIBIPT_VERSION >= 0x201) */
> +#endif /* (LIBIPT_VERSION >= 0x201) */
>
> #if (LIBIPT_VERSION >= 0x202)
> case ptev_trig:
> @@ -3064,7 +3064,7 @@ pt_print_packet (const struct pt_packet *packet)
> packet->payload.ptw.payload,
> packet->payload.ptw.ip ? (" ip") : (""));
> break;
> -#endif /* defined (LIBIPT_VERSION >= 0x200) */
> +#endif /* (LIBIPT_VERSION >= 0x200) */
>
> #if (LIBIPT_VERSION >= 0x201)
> case ppt_cfe:
> @@ -3077,7 +3077,7 @@ pt_print_packet (const struct pt_packet *packet)
> gdb_printf (("evd %u: 0x%" PRIx64 ""), packet->payload.evd.type,
> packet->payload.evd.payload);
> break;
> -#endif /* defined (LIBIPT_VERSION >= 0x201) */
> +#endif /* (LIBIPT_VERSION >= 0x201) */
> }
> }
>
> --
> 2.34.1
>
> Intel Deutschland GmbH
> Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
> Tel: +49 89 991 430, www.intel.de
> Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Seat: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
>
Approved-By: Simon Marchi <simon.marchi@efficios.com>
(even though you don't need an approval for this because you're the
maintainer, and I would consider this obvious anyway)
Simon
prev parent reply other threads:[~2026-05-04 14:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 7:16 Markus Metzger
2026-05-04 7:16 ` [PATCH] gdb: fix an issue with thread list corruption Markus Metzger
2026-05-04 15:30 ` Simon Marchi
2026-05-05 5:04 ` Metzger, Markus T
2026-05-05 15:51 ` Simon Marchi
2026-05-06 5:43 ` Metzger, Markus T
2026-05-06 18:36 ` Simon Marchi
2026-05-07 7:36 ` Metzger, Markus T
2026-05-07 15:11 ` Simon Marchi
2026-05-11 7:25 ` Metzger, Markus T
2026-05-11 10:05 ` Metzger, Markus T
2026-05-12 6:36 ` Metzger, Markus T
2026-05-13 14:33 ` Tom Tromey
2026-05-13 17:05 ` Tom Tromey
2026-05-14 22:07 ` Thiago Jung Bauermann
2026-05-04 7:16 ` [PATCH] gdb, remote: fix notify debug nullptr dereference Markus Metzger
2026-05-04 15:40 ` Simon Marchi
2026-05-04 7:16 ` [PATCH] gdb, testsuite: increase timeout in gdb.threads/attach-non-stop.exp Markus Metzger
2026-05-04 15:49 ` Simon Marchi
2026-05-05 6:15 ` Metzger, Markus T
2026-05-05 15:54 ` Simon Marchi
2026-05-06 6:33 ` Metzger, Markus T
2026-05-04 7:16 ` [PATCH] gdb: update store_integer's comment Markus Metzger
2026-05-04 15:52 ` Simon Marchi
2026-05-04 7:16 ` [PATCH] gdb: use correct target in notify_thread_exited() Markus Metzger
2026-05-04 16:06 ` Simon Marchi
2026-05-05 7:56 ` Metzger, Markus T
2026-05-05 16:10 ` Simon Marchi
2026-05-06 6:56 ` Metzger, Markus T
2026-05-04 7:16 ` [PATCH v2] gdb, btrace: support libipt v2.2 events Markus Metzger
2026-05-04 12:08 ` Eli Zaretskii
2026-05-04 14:00 ` Metzger, Markus T
2026-05-04 15:04 ` Eli Zaretskii
2026-05-05 4:32 ` Metzger, Markus T
2026-05-05 5:12 ` Eli Zaretskii
2026-05-04 14:44 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8466c0-1b81-4e4d-86f9-71a8276ad57e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox