From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2YyfLdyw+Gnk8BIAWB0awg (envelope-from ) for ; Mon, 04 May 2026 10:44:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1777905884; bh=exUMsfrzuVFveVITGQ7djpuulDD4xBv1nC6y1x2IL88=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mN+zS2pFwVenYnHcfqTeGBTrAtSJfiOb41KsyfZsSHhqhutFsXV4xgsbpZm8ymm08 YFRREKyXSRmgm1VhmX6ikqEE0gztUxGxMPQKRWrKRE++hAd1B889iaDB5hh7LgBD2U ViqyTQfoUecQAaJsfBcoL7fqhdq8cm/8ifu9nbto= Received: by simark.ca (Postfix, from userid 112) id B5DBF1E0BA; Mon, 04 May 2026 10:44:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AzmJg+16; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 69A111E067 for ; Mon, 04 May 2026 10:44:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 027FB4B9DB51 for ; Mon, 4 May 2026 14:44:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 027FB4B9DB51 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AzmJg+16 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 04E2D4BA2E23 for ; Mon, 4 May 2026 14:44:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04E2D4BA2E23 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 04E2D4BA2E23 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777905854; cv=none; b=p4B/ctukHePp2mjc+pB7SDRqShmS3eQeVieCoMD+9roEnC9bAl87RHoEn5tD2Ith8hkAtNkHzUZbKljQ4pNT5BmxPBb5RFbVwLVqT1vZ4j8492HtOZoky4D12yIuaeiN11my7n0ZUbmrnnV/QGezogtXdXb8npT2/VW5CX4QIH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777905854; c=relaxed/simple; bh=exUMsfrzuVFveVITGQ7djpuulDD4xBv1nC6y1x2IL88=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=acxCAo7WvgK1wWb8KRvfHH0KNux07S+B2L22dizltI+v3cRqVsMiSfdz68dXOuokOOPBGaQWaQFL+TfNEcAOxupD57Up3SrdunpKZvypU61qvWN/lJ9iWaX1wo+ta6fgLqo9JgoX0e/GbnsiVHmnxcO2VcEIxhvKa5FKCSuCb+o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 04E2D4BA2E23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1777905852; bh=exUMsfrzuVFveVITGQ7djpuulDD4xBv1nC6y1x2IL88=; h=Date:Subject:To:References:From:In-Reply-To:From; b=AzmJg+16sz97dUI7spYPf5pxohVcl0vc0ok4FzcenDFhBMvXPxLxixs7w74onfkpE eQOrJRdaEfQvF8aye1ElI03wsvS1LTMx7nm7HEVzEx7pmzM/H3G1pMPyRDCLUmpEv0 3LPKjow3Aj8go3g/tY6g50f9HZlfZcxCueT2XwZo= Received: by simark.ca (Postfix) id 4C01A1E067; Mon, 04 May 2026 10:44:11 -0400 (EDT) Message-ID: <5b8466c0-1b81-4e4d-86f9-71a8276ad57e@simark.ca> Date: Mon, 4 May 2026 10:44:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, btrace: fix wrong #endif comments To: Markus Metzger , gdb-patches@sourceware.org References: <20260504071636.1571615-1-markus.t.metzger@intel.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260504071636.1571615-1-markus.t.metzger@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/4/26 3:16 AM, Markus Metzger wrote: > --- > gdb/btrace.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/btrace.c b/gdb/btrace.c > index f9c6f0e5b6a..ef152c531fb 100644 > --- a/gdb/btrace.c > +++ b/gdb/btrace.c > @@ -1283,7 +1283,7 @@ decode_interrupt_vector (const uint8_t vector) > > return nullptr; > } > -#endif /* defined (LIBIPT_VERSION >= 0x201) */ > +#endif /* (LIBIPT_VERSION >= 0x201) */ > > /* Handle instruction decode events (libipt-v2). */ > > @@ -1596,7 +1596,7 @@ handle_pt_insn_events (struct btrace_thread_info *btinfo, > handle_pt_aux_insn (btinfo, aux_string, pc); > break; > } > -#endif /* defined (LIBIPT_VERSION >= 0x201) */ > +#endif /* (LIBIPT_VERSION >= 0x201) */ > > #if (LIBIPT_VERSION >= 0x202) > case ptev_trig: > @@ -3064,7 +3064,7 @@ pt_print_packet (const struct pt_packet *packet) > packet->payload.ptw.payload, > packet->payload.ptw.ip ? (" ip") : ("")); > break; > -#endif /* defined (LIBIPT_VERSION >= 0x200) */ > +#endif /* (LIBIPT_VERSION >= 0x200) */ > > #if (LIBIPT_VERSION >= 0x201) > case ppt_cfe: > @@ -3077,7 +3077,7 @@ pt_print_packet (const struct pt_packet *packet) > gdb_printf (("evd %u: 0x%" PRIx64 ""), packet->payload.evd.type, > packet->payload.evd.payload); > break; > -#endif /* defined (LIBIPT_VERSION >= 0x201) */ > +#endif /* (LIBIPT_VERSION >= 0x201) */ > } > } > > -- > 2.34.1 > > Intel Deutschland GmbH > Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany > Tel: +49 89 991 430, www.intel.de > Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell > Chairperson of the Supervisory Board: Nicole Lau > Registered Seat: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > Approved-By: Simon Marchi (even though you don't need an approval for this because you're the maintainer, and I would consider this obvious anyway) Simon