RE: [PATCH] gdb: fix an issue with thread list corruption

["Metzger, Markus T" <markus.t.metzger@intel.com>]

>>The general issue is that safe-iterations should not be nested.  They should
>>only
>>be used with the intent of deleting the current item.  A comment may be
>more
>>effective at preventing mis-use.
>>
>>Both for_each_thread() and find_thread() use all_threads_safe().  They
>>probably
>>shouldn't.  So, instead of fixing this one case by not using for_each_thread(),
>>we
>>should probably change for_each_thread() to use all_threads() and find
>those
>>few
>>cases, if any, that do use for_each_thread() to delete threads and change
>>them
>>to explicitly use all_threads_safe().
>
>It turns out that there are only few calls to for_each_thread() and it looks like
>one such call in mi/mi-main.c would run into a similar issue that this patch
>fixes for infcmd.c.  I have not found a call that deletes the thread in the
>callback.
>
>I'm testing a patch [1] that changes for_each_thread().

Sent as https://sourceware.org/pipermail/gdb-patches/2026-May/227320.html.

This replaces this patch.

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928