Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Cc: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Subject: [PATCH] gdb: update store_integer's comment
Date: Mon,  4 May 2026 07:16:34 +0000	[thread overview]
Message-ID: <20260504071636.1571615-5-markus.t.metzger@intel.com> (raw)
In-Reply-To: <20260504071636.1571615-1-markus.t.metzger@intel.com>

From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>

The comment of store_integer seems slightly outdated and does not
refer to the variants that take an array view.  Update the comment.
---
 gdb/extract-store-integer.c | 4 ++--
 gdb/extract-store-integer.h | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/gdb/extract-store-integer.c b/gdb/extract-store-integer.c
index a7bce99362d..66ddae33aa8 100644
--- a/gdb/extract-store-integer.c
+++ b/gdb/extract-store-integer.c
@@ -129,8 +129,8 @@ extract_typed_address (const gdb_byte *buf, struct type *type)
   return gdbarch_pointer_to_address (type->arch (), type, buf);
 }
 
-/* All 'store' functions accept a host-format integer and store a
-   target-format integer at ADDR which is LEN bytes long.  */
+/* Take a host-format integer VAL and store it as a target-format
+   integer at DST.  */
 template<typename T, typename>
 void
 store_integer (gdb::array_view<gdb_byte> dst, enum bfd_endian byte_order,
diff --git a/gdb/extract-store-integer.h b/gdb/extract-store-integer.h
index 76dfd49d62a..16a6a852bf7 100644
--- a/gdb/extract-store-integer.h
+++ b/gdb/extract-store-integer.h
@@ -57,7 +57,8 @@ extern CORE_ADDR extract_typed_address (const gdb_byte *buf,
 					struct type *type);
 
 /* All 'store' functions accept a host-format integer and store a
-   target-format integer at ADDR which is LEN bytes long.  */
+   target-format integer, either at DST, which contains its size,
+   or at ADDR, which is LEN bytes long.  */
 
 template<typename T, typename = RequireLongest<T>>
 extern void store_integer (gdb::array_view<gdb_byte> dst,
-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  parent reply	other threads:[~2026-05-04  7:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04  7:16 [PATCH] gdb, btrace: fix wrong #endif comments Markus Metzger
2026-05-04  7:16 ` [PATCH] gdb: fix an issue with thread list corruption Markus Metzger
2026-05-04 15:30   ` Simon Marchi
2026-05-05  5:04     ` Metzger, Markus T
2026-05-05 15:51       ` Simon Marchi
2026-05-06  5:43         ` Metzger, Markus T
2026-05-06 18:36           ` Simon Marchi
2026-05-07  7:36             ` Metzger, Markus T
2026-05-07 15:11               ` Simon Marchi
2026-05-11  7:25                 ` Metzger, Markus T
2026-05-11 10:05                   ` Metzger, Markus T
2026-05-12  6:36                     ` Metzger, Markus T
2026-05-13 14:33                     ` Tom Tromey
2026-05-13 17:05                       ` Tom Tromey
2026-05-14 22:07                   ` Thiago Jung Bauermann
2026-05-04  7:16 ` [PATCH] gdb, remote: fix notify debug nullptr dereference Markus Metzger
2026-05-04 15:40   ` Simon Marchi
2026-05-04  7:16 ` [PATCH] gdb, testsuite: increase timeout in gdb.threads/attach-non-stop.exp Markus Metzger
2026-05-04 15:49   ` Simon Marchi
2026-05-05  6:15     ` Metzger, Markus T
2026-05-05 15:54       ` Simon Marchi
2026-05-06  6:33         ` Metzger, Markus T
2026-05-04  7:16 ` Markus Metzger [this message]
2026-05-04 15:52   ` [PATCH] gdb: update store_integer's comment Simon Marchi
2026-05-04  7:16 ` [PATCH] gdb: use correct target in notify_thread_exited() Markus Metzger
2026-05-04 16:06   ` Simon Marchi
2026-05-05  7:56     ` Metzger, Markus T
2026-05-05 16:10       ` Simon Marchi
2026-05-06  6:56         ` Metzger, Markus T
2026-05-04  7:16 ` [PATCH v2] gdb, btrace: support libipt v2.2 events Markus Metzger
2026-05-04 12:08   ` Eli Zaretskii
2026-05-04 14:00     ` Metzger, Markus T
2026-05-04 15:04       ` Eli Zaretskii
2026-05-05  4:32         ` Metzger, Markus T
2026-05-05  5:12           ` Eli Zaretskii
2026-05-04 14:44 ` [PATCH] gdb, btrace: fix wrong #endif comments Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504071636.1571615-5-markus.t.metzger@intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tankut.baris.aktemur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox