From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kYH5MA9I+GkuuhEAWB0awg (envelope-from ) for ; Mon, 04 May 2026 03:17:35 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jgeAznyy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BD6FC1E0BA; Mon, 04 May 2026 03:17:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 632D41E093 for ; Mon, 04 May 2026 03:17:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D86EF4BA9018 for ; Mon, 4 May 2026 07:17:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D86EF4BA9018 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jgeAznyy Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by sourceware.org (Postfix) with ESMTPS id D69B54BAE7DE for ; Mon, 4 May 2026 07:16:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D69B54BAE7DE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D69B54BAE7DE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777879020; cv=none; b=eU8EvbtCbq/iHx3/YrGQ5jJAnvNeT2YQZiia0DYno9hCJAe1n6HszGuq2iV4NPRd0NYn1AyYbpudsULCM9jCeJ3v4f2kWGu/cb2Xyg0GSlf/1Lun2LS1f2/YbRmd97lcnDQraiRIRuklglxOwh7LNYMECfNhn4tmQ+OL7XvTLlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777879020; c=relaxed/simple; bh=freB7DVDR8r7dpD/MGVUn9WWPwlC8bS6EQI1T/jKTEA=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=O3sAoxvlYJQxt7faOwXB4x10xGnUManbRFFtXW1CvtIzb62HRpMWMtFEOVYPIqgdq7u0zsb3JePQmbH8yzv+x7lFbHivYleaQDaEoMtwzTXJ6J2FeDVFmpYcRhT6sUAKXuTWVx97gV0klIrDJgpPXgqSKapDE/ru9oLPRocya6E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D69B54BAE7DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777879020; x=1809415020; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=freB7DVDR8r7dpD/MGVUn9WWPwlC8bS6EQI1T/jKTEA=; b=jgeAznyyk3SOhmk4vXPyKooIbXKOVvr1z2V5P0rWunxubVCHCiZIv/Fj QNsDL7u9BWtLpCd+7AoG8c8hWJ4QvpUKp9Ut92PelcGcGq8Y8FXrp2FTG 526wmyuVhjyjLn6c7G40FSjzy19CpFXCh+NeeMWaKdBoPSUkklaRBP37x hB3OWzQKnlxZnz3xM+B6351zUzEvWNNTdUg97o4zTYkq4Qm1Ico+ayEcA LUMWGns43rMjrufwHGkESw1DwUIzuszGcRY4xTba02OXu2Z4N2NHQYLis DXOSYrIrXqcY57fseKoZAszDycBadE2FjGfZojag3o3mMQGEZLMyiVU6n A==; X-CSE-ConnectionGUID: T4kQvGGURYe4yjNvT5eZOA== X-CSE-MsgGUID: BgtmDHbDQNeU0uF2qzRyUg== X-IronPort-AV: E=McAfee;i="6800,10657,11775"; a="78926009" X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="78926009" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 00:16:57 -0700 X-CSE-ConnectionGUID: ZY/7u9wATb+gSvLO4Ih4CA== X-CSE-MsgGUID: FFWMHq8eTUyovSby3XuDWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="237221356" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 00:16:52 -0700 From: Markus Metzger To: gdb-patches@sourceware.org Cc: Tankut Baris Aktemur Subject: [PATCH] gdb: update store_integer's comment Date: Mon, 4 May 2026 07:16:34 +0000 Message-Id: <20260504071636.1571615-5-markus.t.metzger@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260504071636.1571615-1-markus.t.metzger@intel.com> References: <20260504071636.1571615-1-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Tankut Baris Aktemur The comment of store_integer seems slightly outdated and does not refer to the variants that take an array view. Update the comment. --- gdb/extract-store-integer.c | 4 ++-- gdb/extract-store-integer.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/extract-store-integer.c b/gdb/extract-store-integer.c index a7bce99362d..66ddae33aa8 100644 --- a/gdb/extract-store-integer.c +++ b/gdb/extract-store-integer.c @@ -129,8 +129,8 @@ extract_typed_address (const gdb_byte *buf, struct type *type) return gdbarch_pointer_to_address (type->arch (), type, buf); } -/* All 'store' functions accept a host-format integer and store a - target-format integer at ADDR which is LEN bytes long. */ +/* Take a host-format integer VAL and store it as a target-format + integer at DST. */ template void store_integer (gdb::array_view dst, enum bfd_endian byte_order, diff --git a/gdb/extract-store-integer.h b/gdb/extract-store-integer.h index 76dfd49d62a..16a6a852bf7 100644 --- a/gdb/extract-store-integer.h +++ b/gdb/extract-store-integer.h @@ -57,7 +57,8 @@ extern CORE_ADDR extract_typed_address (const gdb_byte *buf, struct type *type); /* All 'store' functions accept a host-format integer and store a - target-format integer at ADDR which is LEN bytes long. */ + target-format integer, either at DST, which contains its size, + or at ADDR, which is LEN bytes long. */ template> extern void store_integer (gdb::array_view dst, -- 2.34.1 Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 89 991 430, www.intel.de Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell Chairperson of the Supervisory Board: Nicole Lau Registered Seat: Munich Commercial Register: Amtsgericht Muenchen HRB 186928