Re: [PATCH] gdb, remote: fix notify debug nullptr dereference

[Simon Marchi <simark@simark.ca>]

On 5/4/26 3:16 AM, Markus Metzger wrote:
> In remote_target:push_stop_reply, notif debug prints an element that has
> been moved.  Print the element at the destination, instead.

So, there is a clang-tidy check for that, and indeed it finds it (and
more, but I'm just pasting the relevant one):

    $ clang-tidy  '-checks=bugprone-use-after-move' remote.c
    ...
    /home/smarchi/src/binutils-gdb/gdb/remote.c:8409:3: warning: 'new_event' used after it was moved [bugprone-use-after-move]
     8409 |                 new_event->ptid.to_string ().c_str (),
          |                 ^
    /home/smarchi/src/binutils-gdb/gdb/remote.c:8404:24: note: move occurred here
     8404 |   rs->stop_reply_queue.push_back (std::move (new_event));

I think we should set up a .clang-tidy file with the checks we care
about an run it in the CI, I'll look into that.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon