* [PATCH] sim: microblaze: target endianess recognition fix
[not found] <1063903693.5257056.1496148658168.ref@mail.yahoo.com>
@ 2017-05-30 12:50 ` Andrea Corallo via gdb-patches
2017-05-30 15:34 ` Michael Eager
0 siblings, 1 reply; 5+ messages in thread
From: Andrea Corallo via gdb-patches @ 2017-05-30 12:50 UTC (permalink / raw)
To: gdb-patches
Hello,
seams the microblaze simulator is missing endianness conversions running on small endian machine.
This small patch does the job for me.
I hope all is ok, is my first contribution so please forgive me in case I'm missing something.
sim/microblaze/ChangeLog:
2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it>
* interp.c: (target_big_endian): target endianess recognition fix.
---
sim/microblaze/interp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
index e619cf8..75fc98b 100644
--- a/sim/microblaze/interp.c
+++ b/sim/microblaze/interp.c
@@ -31,7 +31,7 @@
#include "microblaze-dis.h"
-#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN)
+#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
static unsigned long
microblaze_extract_unsigned_integer (unsigned char *addr, int len)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim: microblaze: target endianess recognition fix
2017-05-30 12:50 ` [PATCH] sim: microblaze: target endianess recognition fix Andrea Corallo via gdb-patches
@ 2017-05-30 15:34 ` Michael Eager
2017-05-30 16:16 ` Andrea Corallo via gdb-patches
0 siblings, 1 reply; 5+ messages in thread
From: Michael Eager @ 2017-05-30 15:34 UTC (permalink / raw)
To: Andrea Corallo, gdb-patches
On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote:
> Hello,
> seams the microblaze simulator is missing endianness conversions running on small endian machine.
> This small patch does the job for me.
> I hope all is ok, is my first contribution so please forgive me in case I'm missing something.
>
> sim/microblaze/ChangeLog:
>
> 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it>
> * interp.c: (target_big_endian): target endianess recognition fix.
> ---
> sim/microblaze/interp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
> index e619cf8..75fc98b 100644
> --- a/sim/microblaze/interp.c
> +++ b/sim/microblaze/interp.c
> @@ -31,7 +31,7 @@
>
> #include "microblaze-dis.h"
>
> -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN)
> +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
>
> static unsigned long
> microblaze_extract_unsigned_integer (unsigned char *addr, int len)
OK to apply. If you don't have write privileges, let me know.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim: microblaze: target endianess recognition fix
2017-05-30 15:34 ` Michael Eager
@ 2017-05-30 16:16 ` Andrea Corallo via gdb-patches
2017-06-02 7:03 ` Andrea Corallo via gdb-patches
0 siblings, 1 reply; 5+ messages in thread
From: Andrea Corallo via gdb-patches @ 2017-05-30 16:16 UTC (permalink / raw)
To: Michael Eager, gdb-patches
I guess I don't.
Thanks
K.
Il Martedì 30 Maggio 2017 17:34, Michael Eager <eager@eagerm.com> ha scritto:
On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote:
> Hello,
> seams the microblaze simulator is missing endianness conversions running on small endian machine.
> This small patch does the job for me.
> I hope all is ok, is my first contribution so please forgive me in case I'm missing something.
>
> sim/microblaze/ChangeLog:
>
> 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it>
> * interp.c: (target_big_endian): target endianess recognition fix.
> ---
> sim/microblaze/interp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
> index e619cf8..75fc98b 100644
> --- a/sim/microblaze/interp.c
> +++ b/sim/microblaze/interp.c
> @@ -31,7 +31,7 @@
>
> #include "microblaze-dis.h"
>
> -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN)
> +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
>
> static unsigned long
> microblaze_extract_unsigned_integer (unsigned char *addr, int len)
OK to apply. If you don't have write privileges, let me know.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim: microblaze: target endianess recognition fix
2017-05-30 16:16 ` Andrea Corallo via gdb-patches
@ 2017-06-02 7:03 ` Andrea Corallo via gdb-patches
2017-06-02 15:06 ` Michael Eager
0 siblings, 1 reply; 5+ messages in thread
From: Andrea Corallo via gdb-patches @ 2017-06-02 7:03 UTC (permalink / raw)
To: GDB Patches
Hi Micheal,
re reading my last mail I've realized it was maybe not so clear.
I don't have write privileges so could you apply the patch?
Thanks Andrea
Il Martedì 30 Maggio 2017 18:16, Andrea Corallo via gdb-patches <gdb-patches@sourceware.org> ha scritto:
I guess I don't.
Thanks
K.
Il Martedì 30 Maggio 2017 17:34, Michael Eager <eager@eagerm.com> ha scritto:
On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote:
> Hello,
> seams the microblaze simulator is missing endianness conversions running on small endian machine.
> This small patch does the job for me.
> I hope all is ok, is my first contribution so please forgive me in case I'm missing something.
>
> sim/microblaze/ChangeLog:
>
> 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it>
> * interp.c: (target_big_endian): target endianess recognition fix.
> ---
> sim/microblaze/interp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
> index e619cf8..75fc98b 100644
> --- a/sim/microblaze/interp.c
> +++ b/sim/microblaze/interp.c
> @@ -31,7 +31,7 @@
>
> #include "microblaze-dis.h"
>
> -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN)
> +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
>
> static unsigned long
> microblaze_extract_unsigned_integer (unsigned char *addr, int len)
OK to apply. If you don't have write privileges, let me know.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim: microblaze: target endianess recognition fix
2017-06-02 7:03 ` Andrea Corallo via gdb-patches
@ 2017-06-02 15:06 ` Michael Eager
0 siblings, 0 replies; 5+ messages in thread
From: Michael Eager @ 2017-06-02 15:06 UTC (permalink / raw)
To: Andrea Corallo, GDB Patches
On 06/02/2017 12:03 AM, Andrea Corallo via gdb-patches wrote:
> Hi Micheal,
> re reading my last mail I've realized it was maybe not so clear.
> I don't have write privileges so could you apply the patch?
> Thanks Andrea
>
>
> Il Martedì 30 Maggio 2017 18:16, Andrea Corallo via gdb-patches <gdb-patches@sourceware.org> ha scritto:
>
>
>
> I guess I don't.
>
> Thanks
>
> K.
>
>
>
>
> Il Martedì 30 Maggio 2017 17:34, Michael Eager <eager@eagerm.com> ha scritto:
>
>
>
> On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote:
>
>> Hello,
>> seams the microblaze simulator is missing endianness conversions running on small endian machine.
>> This small patch does the job for me.
>> I hope all is ok, is my first contribution so please forgive me in case I'm missing something.
>>
>> sim/microblaze/ChangeLog:
>>
>> 2017-05-30 Andrea Corallo <andrea_corallo@yahoo.it>
>> * interp.c: (target_big_endian): target endianess recognition fix.
>> ---
>> sim/microblaze/interp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
>> index e619cf8..75fc98b 100644
>> --- a/sim/microblaze/interp.c
>> +++ b/sim/microblaze/interp.c
>> @@ -31,7 +31,7 @@
>>
>> #include "microblaze-dis.h"
>>
>> -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN)
>> +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
>>
>> static unsigned long
>> microblaze_extract_unsigned_integer (unsigned char *addr, int len)
>
> OK to apply. If you don't have write privileges, let me know.
>
Applied to GDB master. Commit e7cd268.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-02 15:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1063903693.5257056.1496148658168.ref@mail.yahoo.com>
2017-05-30 12:50 ` [PATCH] sim: microblaze: target endianess recognition fix Andrea Corallo via gdb-patches
2017-05-30 15:34 ` Michael Eager
2017-05-30 16:16 ` Andrea Corallo via gdb-patches
2017-06-02 7:03 ` Andrea Corallo via gdb-patches
2017-06-02 15:06 ` Michael Eager
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox