Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Eager <eager@eagerm.com>
To: Andrea Corallo <andrea_corallo@yahoo.it>,
	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: microblaze: target endianess recognition fix
Date: Fri, 02 Jun 2017 15:06:00 -0000	[thread overview]
Message-ID: <59317F0C.8060600@eagerm.com> (raw)
In-Reply-To: <1548407488.156929.1496387026956@mail.yahoo.com>

On 06/02/2017 12:03 AM, Andrea Corallo via gdb-patches wrote:
> Hi Micheal,
> re reading my last mail I've realized it was maybe not so clear.
> I don't have write privileges so could you apply the patch?
> Thanks   Andrea
>
>
> Il Martedì 30 Maggio 2017 18:16, Andrea Corallo via gdb-patches <gdb-patches@sourceware.org> ha scritto:
>
>
>
> I guess I don't.
>
> Thanks
>
> K.
>
>
>
>
> Il Martedì 30 Maggio 2017 17:34, Michael Eager <eager@eagerm.com> ha scritto:
>
>
>
> On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote:
>
>> Hello,
>> seams the microblaze simulator is missing endianness conversions running on small endian machine.
>> This small patch does the job for me.
>> I hope all is ok, is my first contribution so please forgive me in case I'm missing something.
>>
>> sim/microblaze/ChangeLog:
>>
>> 2017-05-30  Andrea Corallo  <andrea_corallo@yahoo.it>
>> * interp.c: (target_big_endian): target endianess recognition fix.
>> ---
>> sim/microblaze/interp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
>> index e619cf8..75fc98b 100644
>> --- a/sim/microblaze/interp.c
>> +++ b/sim/microblaze/interp.c
>> @@ -31,7 +31,7 @@
>>
>> #include "microblaze-dis.h"
>>
>> -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN)
>> +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
>>
>> static unsigned long
>> microblaze_extract_unsigned_integer (unsigned char *addr, int len)
>
> OK to apply.  If you don't have write privileges, let me know.
>

Applied to GDB master. Commit e7cd268.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


      reply	other threads:[~2017-06-02 15:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1063903693.5257056.1496148658168.ref@mail.yahoo.com>
2017-05-30 12:50 ` Andrea Corallo via gdb-patches
2017-05-30 15:34   ` Michael Eager
2017-05-30 16:16     ` Andrea Corallo via gdb-patches
2017-06-02  7:03       ` Andrea Corallo via gdb-patches
2017-06-02 15:06         ` Michael Eager [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59317F0C.8060600@eagerm.com \
    --to=eager@eagerm.com \
    --cc=andrea_corallo@yahoo.it \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox