From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44610 invoked by alias); 2 Jun 2017 15:06:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44571 invoked by uid 89); 2 Jun 2017 15:06:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=alto, Park, park X-HELO: resqmta-po-05v.sys.comcast.net Received: from resqmta-po-05v.sys.comcast.net (HELO resqmta-po-05v.sys.comcast.net) (96.114.154.164) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Jun 2017 15:06:51 +0000 Received: from resomta-po-04v.sys.comcast.net ([96.114.154.228]) by resqmta-po-05v.sys.comcast.net with SMTP id Go8udWoyprWIEGoA9dfedA; Fri, 02 Jun 2017 15:06:53 +0000 Received: from vm-fedora21.eagercon.com ([IPv6:2601:647:4d04:5190:20c:29ff:fe70:d3be]) by resomta-po-04v.sys.comcast.net with SMTP id GoA8dkl8giPzBGoA9dnOdz; Fri, 02 Jun 2017 15:06:53 +0000 Subject: Re: [PATCH] sim: microblaze: target endianess recognition fix To: Andrea Corallo , GDB Patches References: <1063903693.5257056.1496148658168.ref@mail.yahoo.com> <1063903693.5257056.1496148658168@mail.yahoo.com> <592D910B.9040503@eagerm.com> <1701357949.5649512.1496160941429@mail.yahoo.com> <1548407488.156929.1496387026956@mail.yahoo.com> From: Michael Eager Message-ID: <59317F0C.8060600@eagerm.com> Date: Fri, 02 Jun 2017 15:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1548407488.156929.1496387026956@mail.yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-CMAE-Envelope: MS4wfMwZk6Z3GVhSSDB8MvTYZ7OrOwRNNra/8fjj/wNGk+cobsZZAEwkRQXPIc4hf0WTft8GTFamE4ElFheiIMFNI3ba6jrbVKHKIot/zYBnyb7mG4vi/rsB n7PFKdgWjFrSUoerkYzdGQgAU5DXiguJjOqEsqGuZTt6uTNHC/nLMB4l/E2Ot7Dr3Cbw7ZFB+ZINXSLWNNfjXc95sF+pIFXHhww= X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00050.txt.bz2 On 06/02/2017 12:03 AM, Andrea Corallo via gdb-patches wrote: > Hi Micheal, > re reading my last mail I've realized it was maybe not so clear. > I don't have write privileges so could you apply the patch? > Thanks Andrea > > > Il Marted=C3=AC 30 Maggio 2017 18:16, Andrea Corallo via gdb-patches ha scritto: > > > > I guess I don't. > > Thanks > > K. > > > > > Il Marted=C3=AC 30 Maggio 2017 17:34, Michael Eager ha= scritto: > > > > On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote: > >> Hello, >> seams the microblaze simulator is missing endianness conversions running= on small endian machine. >> This small patch does the job for me. >> I hope all is ok, is my first contribution so please forgive me in case = I'm missing something. >> >> sim/microblaze/ChangeLog: >> >> 2017-05-30 Andrea Corallo >> * interp.c: (target_big_endian): target endianess recognition fix. >> --- >> sim/microblaze/interp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c >> index e619cf8..75fc98b 100644 >> --- a/sim/microblaze/interp.c >> +++ b/sim/microblaze/interp.c >> @@ -31,7 +31,7 @@ >> >> #include "microblaze-dis.h" >> >> -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER =3D=3D BIG_ENDIAN) >> +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER =3D=3D BFD_ENDIAN_= BIG) >> >> static unsigned long >> microblaze_extract_unsigned_integer (unsigned char *addr, int len) > > OK to apply. If you don't have write privileges, let me know. > Applied to GDB master. Commit e7cd268. --=20 Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077