From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124041 invoked by alias); 30 May 2017 15:34:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124006 invoked by uid 89); 30 May 2017 15:34:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=HTo:D*it, Hx-languages-length:1220, alto, Park X-HELO: resqmta-po-09v.sys.comcast.net Received: from resqmta-po-09v.sys.comcast.net (HELO resqmta-po-09v.sys.comcast.net) (96.114.154.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 May 2017 15:34:34 +0000 Received: from resomta-po-12v.sys.comcast.net ([96.114.154.236]) by resqmta-po-09v.sys.comcast.net with SMTP id Fj92dqNLLDKCQFjAKdVewT; Tue, 30 May 2017 15:34:36 +0000 Received: from vm-fedora21.eagercon.com ([IPv6:2601:647:4d04:5190:20c:29ff:fe70:d3be]) by resomta-po-12v.sys.comcast.net with SMTP id FjAJdWttadPKDFjAKdXMjL; Tue, 30 May 2017 15:34:36 +0000 Subject: Re: [PATCH] sim: microblaze: target endianess recognition fix To: Andrea Corallo , "gdb-patches@sourceware.org" References: <1063903693.5257056.1496148658168.ref@mail.yahoo.com> <1063903693.5257056.1496148658168@mail.yahoo.com> From: Michael Eager Message-ID: <592D910B.9040503@eagerm.com> Date: Tue, 30 May 2017 15:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1063903693.5257056.1496148658168@mail.yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfAC5gzRayD+jnwYkoD3I+41XBpShgm//oXi6BZPI776tBKeVh3bps2F+62KuX6LVW4JLM8ejLvoKe2KxZtnh/x4bM4MAE3lpDns2WohBoxSGpS0Chlxm BFsSmmvMJXUplFX4h6ZLT5npOhVs7SdVXVSRoiTWXtYLaSbC+n7obbYECmDaCwvADuYvW2ty7oto23DIpBr6HjCHNeRrAer9hgk= X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00622.txt.bz2 On 05/30/2017 05:50 AM, Andrea Corallo via gdb-patches wrote: > Hello, > seams the microblaze simulator is missing endianness conversions running on small endian machine. > This small patch does the job for me. > I hope all is ok, is my first contribution so please forgive me in case I'm missing something. > > sim/microblaze/ChangeLog: > > 2017-05-30 Andrea Corallo > * interp.c: (target_big_endian): target endianess recognition fix. > --- > sim/microblaze/interp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c > index e619cf8..75fc98b 100644 > --- a/sim/microblaze/interp.c > +++ b/sim/microblaze/interp.c > @@ -31,7 +31,7 @@ > > #include "microblaze-dis.h" > > -#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BIG_ENDIAN) > +#define target_big_endian (CURRENT_TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > > static unsigned long > microblaze_extract_unsigned_integer (unsigned char *addr, int len) OK to apply. If you don't have write privileges, let me know. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077