From: Pedro Alves <palves@redhat.com>
To: Sandra Loosemore <sandra@codesourcery.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp
Date: Fri, 18 Dec 2015 20:40:00 -0000 [thread overview]
Message-ID: <56746F26.1040903@redhat.com> (raw)
In-Reply-To: <5674636B.6090507@codesourcery.com>
On 12/18/2015 07:50 PM, Sandra Loosemore wrote:
> This patch fixes a think-o in gdb.base/paginate-bg-execution.exp --
> there are two calls to gdb_test with only a single argument. Looking at
> the definition of this proc in lib/gdb.exp, the second argument (the
> output pattern) is not supposed to be optional. For whatever reason, I
> was only seeing failures on remote Windows host testing, but it must
> have been an accident that it appeared to be working elsewhere.
>
> I copied the breakpoint output pattern used elsewhere in the testsuite,
> and confirmed this passes now. OK to commit?
Can you show the gdb.log of the failed run?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-12-18 20:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 19:23 [patch 0/3] fix some gdb.base/paginate-bg-execution.exp problems Sandra Loosemore
2015-12-18 19:31 ` [patch 1/3] make prompt_for_continue call throw_quit directly Sandra Loosemore
2015-12-18 19:34 ` Pedro Alves
2015-12-18 19:44 ` [patch 2/3] reset pagination counts even when stdin is not a tty Sandra Loosemore
2015-12-18 20:17 ` Pedro Alves
2015-12-18 19:50 ` [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp Sandra Loosemore
2015-12-18 20:40 ` Pedro Alves [this message]
2015-12-18 23:49 ` Sandra Loosemore
2015-12-21 11:53 ` Pedro Alves
2015-12-21 12:27 ` Joel Brobecker
2015-12-25 19:39 ` Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56746F26.1040903@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox