Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Sandra Loosemore <sandra@codesourcery.com>,
	gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp
Date: Mon, 21 Dec 2015 12:27:00 -0000	[thread overview]
Message-ID: <20151221122750.GB5564@adacore.com> (raw)
In-Reply-To: <5677E835.4090603@redhat.com>

> If it wasn't supposed to be correct, then it'd be good to add
> an "error" call in gdb_test, to make it a hard error.
> 
> But I think it is supposed to work.  At least
> 
>  $ grep -rn "gdb_test "  | grep -v "\".*\".*\"" | grep -v "\\\\"
> 
> shows many (hundreds) of instances.  With no explicit pattern,
> we end up just matching the prompt, ignoring whatever output
> precedes it.

Yes, I confirm it is supposed to work, or at least it's been
acknowledged to be that way for quite a while. The last time
we discussed it is when we created gdb_test_no_output.

-- 
Joel


  reply	other threads:[~2015-12-21 12:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 19:23 [patch 0/3] fix some gdb.base/paginate-bg-execution.exp problems Sandra Loosemore
2015-12-18 19:31 ` [patch 1/3] make prompt_for_continue call throw_quit directly Sandra Loosemore
2015-12-18 19:34   ` Pedro Alves
2015-12-18 19:44 ` [patch 2/3] reset pagination counts even when stdin is not a tty Sandra Loosemore
2015-12-18 20:17   ` Pedro Alves
2015-12-18 19:50 ` [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp Sandra Loosemore
2015-12-18 20:40   ` Pedro Alves
2015-12-18 23:49     ` Sandra Loosemore
2015-12-21 11:53       ` Pedro Alves
2015-12-21 12:27         ` Joel Brobecker [this message]
2015-12-25 19:39           ` Sandra Loosemore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151221122750.GB5564@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox