From: Sandra Loosemore <sandra@codesourcery.com>
To: gdb-patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: [patch 1/3] make prompt_for_continue call throw_quit directly
Date: Fri, 18 Dec 2015 19:31:00 -0000 [thread overview]
Message-ID: <56745ED5.9020309@codesourcery.com> (raw)
In-Reply-To: <56745D29.504@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
This is the patch previously suggested by Pedro here:
https://sourceware.org/ml/gdb-patches/2015-09/msg00637.html
to fix a problem I ran into when testing on a remote Windows host via
SSH without a terminal or job control. As Pedro said, when typing 'q'
in response to a pagination prompt, there's no possibility of a SIGINT
so we can bypass the parts of quit() handling that are intended to
intercept ^C instead.
I confirmed that this fixes the bogus quit message I observed previously
on Windows host, and did full regression testing on Linux host for
nios2-linux-gnu target.
OK to commit?
-Sandra
[-- Attachment #2: gdb-paginate-1.log --]
[-- Type: text/x-log, Size: 130 bytes --]
2015-12-18 Sandra Loosemore <sandra@codesourcery.com>
gdb/
* utils.c (prompt_for_continue): Call throw_quit directly on 'q'.
[-- Attachment #3: gdb-paginate-1.patch --]
[-- Type: text/x-patch, Size: 309 bytes --]
diff --git a/gdb/utils.c b/gdb/utils.c
index 284fbbb..862a802 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -1868,7 +1868,7 @@ prompt_for_continue (void)
while (*p == ' ' || *p == '\t')
++p;
if (p[0] == 'q')
- quit ();
+ throw_quit ("Quit");
xfree (ignore);
}
immediate_quit--;
next prev parent reply other threads:[~2015-12-18 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 19:23 [patch 0/3] fix some gdb.base/paginate-bg-execution.exp problems Sandra Loosemore
2015-12-18 19:31 ` Sandra Loosemore [this message]
2015-12-18 19:34 ` [patch 1/3] make prompt_for_continue call throw_quit directly Pedro Alves
2015-12-18 19:44 ` [patch 2/3] reset pagination counts even when stdin is not a tty Sandra Loosemore
2015-12-18 20:17 ` Pedro Alves
2015-12-18 19:50 ` [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp Sandra Loosemore
2015-12-18 20:40 ` Pedro Alves
2015-12-18 23:49 ` Sandra Loosemore
2015-12-21 11:53 ` Pedro Alves
2015-12-21 12:27 ` Joel Brobecker
2015-12-25 19:39 ` Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56745ED5.9020309@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox