Re: [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp

[Sandra Loosemore <sandra@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

On 12/21/2015 05:27 AM, Joel Brobecker wrote:
>> If it wasn't supposed to be correct, then it'd be good to add
>> an "error" call in gdb_test, to make it a hard error.
>>
>> But I think it is supposed to work.  At least
>>
>>   $ grep -rn "gdb_test "  | grep -v "\".*\".*\"" | grep -v "\\\\"
>>
>> shows many (hundreds) of instances.  With no explicit pattern,
>> we end up just matching the prompt, ignoring whatever output
>> precedes it.
>
> Yes, I confirm it is supposed to work, or at least it's been
> acknowledged to be that way for quite a while. The last time
> we discussed it is when we created gdb_test_no_output.

OK.  I think this tweak to the comments is obvious enough that I've gone 
ahead and checked it in.

-Sandra


[-- Attachment #2: gdb.log --]
[-- Type: text/x-log, Size: 167 bytes --]

2015-12-25  Sandra Loosemore  <sandra@codesourcery.com>

	gdb/testsuite/
	* lib/gdb.exp (gdb_test): Update comments to clarify that the
	PATTERN argument is optional.

[-- Attachment #3: gdb.patch --]
[-- Type: text/x-patch, Size: 845 bytes --]

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 765ac83..5488c29 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -959,7 +959,9 @@ proc gdb_test_multiple { command message user_code } {
 # COMMAND is the command to execute, send to GDB with send_gdb.  If
 #   this is the null string no command is sent.
 # PATTERN is the pattern to match for a PASS, and must NOT include
-#   the \r\n sequence immediately before the gdb prompt.
+#   the \r\n sequence immediately before the gdb prompt.  This argument
+#   may be omitted to just match the prompt, ignoring whatever output 
+#   precedes it.
 # MESSAGE is an optional message to be printed.  If this is
 #   omitted, then the pass/fail messages use the command string as the
 #   message.  (If this is the empty string, then sometimes we don't