From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4651 invoked by alias); 18 Dec 2015 20:40:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4641 invoked by uid 89); 18 Dec 2015 20:40:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=gdblog, gdb.log, UD:gdb.log X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Dec 2015 20:40:09 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 93B738E236; Fri, 18 Dec 2015 20:40:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBIKe74B011492; Fri, 18 Dec 2015 15:40:07 -0500 Message-ID: <56746F26.1040903@redhat.com> Date: Fri, 18 Dec 2015 20:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sandra Loosemore , gdb-patches Subject: Re: [patch 3/3] add missing gdb_test arguments in paginate-bg-execution.exp References: <56745D29.504@codesourcery.com> <5674636B.6090507@codesourcery.com> In-Reply-To: <5674636B.6090507@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-12/txt/msg00391.txt.bz2 On 12/18/2015 07:50 PM, Sandra Loosemore wrote: > This patch fixes a think-o in gdb.base/paginate-bg-execution.exp -- > there are two calls to gdb_test with only a single argument. Looking at > the definition of this proc in lib/gdb.exp, the second argument (the > output pattern) is not supposed to be optional. For whatever reason, I > was only seeing failures on remote Windows host testing, but it must > have been an accident that it appeared to be working elsewhere. > > I copied the breakpoint output pattern used elsewhere in the testsuite, > and confirmed this passes now. OK to commit? Can you show the gdb.log of the failed run? Thanks, Pedro Alves