* [PATCH] building on musl: #include sys/types.h for mode_t
@ 2015-10-28 20:50 Doug Evans
2015-10-29 11:30 ` Pedro Alves
0 siblings, 1 reply; 4+ messages in thread
From: Doug Evans @ 2015-10-28 20:50 UTC (permalink / raw)
To: gdb-patches
Hi.
Turns out there was a fourth patch. :-)
2015-10-28 Doug Evans <xdje42@gmail.com>
* target.h: #include <sys/types.h>
diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
index a14c6ff..f3fcd6c 100644
--- a/gdb/gdbserver/target.h
+++ b/gdb/gdbserver/target.h
@@ -21,6 +21,7 @@
#ifndef TARGET_H
#define TARGET_H
+#include <sys/types.h> /* for mode_t */
#include "target/target.h"
#include "target/resume.h"
#include "target/wait.h"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] building on musl: #include sys/types.h for mode_t
2015-10-28 20:50 [PATCH] building on musl: #include sys/types.h for mode_t Doug Evans
@ 2015-10-29 11:30 ` Pedro Alves
2015-10-29 11:30 ` Pedro Alves
0 siblings, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2015-10-29 11:30 UTC (permalink / raw)
To: Doug Evans, gdb-patches
On 10/28/2015 05:44 PM, Doug Evans wrote:
> Hi.
Hi there,
>
> Turns out there was a fourth patch. :-)
:-)
>
> 2015-10-28 Doug Evans <xdje42@gmail.com>
>
> * target.h: #include <sys/types.h>
>
> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
> index a14c6ff..f3fcd6c 100644
> --- a/gdb/gdbserver/target.h
> +++ b/gdb/gdbserver/target.h
> @@ -21,6 +21,7 @@
> #ifndef TARGET_H
> #define TARGET_H
>
> +#include <sys/types.h> /* for mode_t */
Where is mode_t referenced? (what's the error?)
> #include "target/target.h"
> #include "target/resume.h"
> #include "target/wait.h"
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] building on musl: #include sys/types.h for mode_t
2015-10-29 11:30 ` Pedro Alves
@ 2015-10-29 11:30 ` Pedro Alves
2015-11-23 1:29 ` Doug Evans
0 siblings, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2015-10-29 11:30 UTC (permalink / raw)
To: Doug Evans, gdb-patches
On 10/28/2015 05:57 PM, Pedro Alves wrote:
> On 10/28/2015 05:44 PM, Doug Evans wrote:
>> Hi.
>
> Hi there,
>
>>
>> Turns out there was a fourth patch. :-)
>
> :-)
>
>>
>> 2015-10-28 Doug Evans <xdje42@gmail.com>
>>
>> * target.h: #include <sys/types.h>
>>
>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>> index a14c6ff..f3fcd6c 100644
>> --- a/gdb/gdbserver/target.h
>> +++ b/gdb/gdbserver/target.h
>> @@ -21,6 +21,7 @@
>> #ifndef TARGET_H
>> #define TARGET_H
>>
>> +#include <sys/types.h> /* for mode_t */
>
> Where is mode_t referenced? (what's the error?)
Nevermind, I didn't notice I was was grepping an old tree,
which predates target->multifs_open.
Patch LGTM.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] building on musl: #include sys/types.h for mode_t
2015-10-29 11:30 ` Pedro Alves
@ 2015-11-23 1:29 ` Doug Evans
0 siblings, 0 replies; 4+ messages in thread
From: Doug Evans @ 2015-11-23 1:29 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
Pedro Alves <palves@redhat.com> writes:
> On 10/28/2015 05:57 PM, Pedro Alves wrote:
>> On 10/28/2015 05:44 PM, Doug Evans wrote:
>>> Hi.
>>
>> Hi there,
>>
>>>
>>> Turns out there was a fourth patch. :-)
>>
>> :-)
>>
>>>
>>> 2015-10-28 Doug Evans <xdje42@gmail.com>
>>>
>>> * target.h: #include <sys/types.h>
>>>
>>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>>> index a14c6ff..f3fcd6c 100644
>>> --- a/gdb/gdbserver/target.h
>>> +++ b/gdb/gdbserver/target.h
>>> @@ -21,6 +21,7 @@
>>> #ifndef TARGET_H
>>> #define TARGET_H
>>>
>>> +#include <sys/types.h> /* for mode_t */
>>
>> Where is mode_t referenced? (what's the error?)
>
> Nevermind, I didn't notice I was was grepping an old tree,
> which predates target->multifs_open.
>
> Patch LGTM.
>
> Thanks,
> Pedro Alves
Committed, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-23 1:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-28 20:50 [PATCH] building on musl: #include sys/types.h for mode_t Doug Evans
2015-10-29 11:30 ` Pedro Alves
2015-10-29 11:30 ` Pedro Alves
2015-11-23 1:29 ` Doug Evans
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox