From: Pedro Alves <palves@redhat.com>
To: Doug Evans <xdje42@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] building on musl: #include sys/types.h for mode_t
Date: Thu, 29 Oct 2015 11:30:00 -0000 [thread overview]
Message-ID: <563112BD.60505@redhat.com> (raw)
In-Reply-To: <56310C96.5050709@redhat.com>
On 10/28/2015 05:57 PM, Pedro Alves wrote:
> On 10/28/2015 05:44 PM, Doug Evans wrote:
>> Hi.
>
> Hi there,
>
>>
>> Turns out there was a fourth patch. :-)
>
> :-)
>
>>
>> 2015-10-28 Doug Evans <xdje42@gmail.com>
>>
>> * target.h: #include <sys/types.h>
>>
>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>> index a14c6ff..f3fcd6c 100644
>> --- a/gdb/gdbserver/target.h
>> +++ b/gdb/gdbserver/target.h
>> @@ -21,6 +21,7 @@
>> #ifndef TARGET_H
>> #define TARGET_H
>>
>> +#include <sys/types.h> /* for mode_t */
>
> Where is mode_t referenced? (what's the error?)
Nevermind, I didn't notice I was was grepping an old tree,
which predates target->multifs_open.
Patch LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-10-28 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 20:50 Doug Evans
2015-10-29 11:30 ` Pedro Alves
2015-10-29 11:30 ` Pedro Alves [this message]
2015-11-23 1:29 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563112BD.60505@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox