From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-127100-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 42831 invoked by alias); 28 Oct 2015 18:24:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 42798 invoked by uid 89); 28 Oct 2015 18:24:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 28 Oct 2015 18:24:00 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (Postfix) with ESMTPS id 8889B8C1C0;	Wed, 28 Oct 2015 18:23:59 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9SINwZE002991;	Wed, 28 Oct 2015 14:23:58 -0400
Message-ID: <563112BD.60505@redhat.com>
Date: Thu, 29 Oct 2015 11:30:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Doug Evans <xdje42@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] building on musl: #include sys/types.h for mode_t
References: <86ziz27urp.fsf@sspiff.org> <56310C96.5050709@redhat.com>
In-Reply-To: <56310C96.5050709@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-10/txt/msg00664.txt.bz2

On 10/28/2015 05:57 PM, Pedro Alves wrote:
> On 10/28/2015 05:44 PM, Doug Evans wrote:
>> Hi.
> 
> Hi there,
> 
>>
>> Turns out there was a fourth patch. :-)
> 
> :-)
> 
>>
>> 2015-10-28  Doug Evans  <xdje42@gmail.com>
>>
>> 	* target.h: #include <sys/types.h>
>>
>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>> index a14c6ff..f3fcd6c 100644
>> --- a/gdb/gdbserver/target.h
>> +++ b/gdb/gdbserver/target.h
>> @@ -21,6 +21,7 @@
>>  #ifndef TARGET_H
>>  #define TARGET_H
>>  
>> +#include <sys/types.h> /* for mode_t */
> 
> Where is mode_t referenced? (what's the error?)

Nevermind, I didn't notice I was was grepping an old tree,
which predates target->multifs_open.

Patch LGTM.

Thanks,
Pedro Alves