From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-127671-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 39635 invoked by alias); 23 Nov 2015 01:29:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 39625 invoked by uid 89); 23 Nov 2015 01:29:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pa0-f45.google.com
Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 23 Nov 2015 01:29:30 +0000
Received: by pabfh17 with SMTP id fh17so179818024pab.0        for <gdb-patches@sourceware.org>; Sun, 22 Nov 2015 17:29:28 -0800 (PST)
X-Received: by 10.98.42.148 with SMTP id q142mr13288547pfq.0.1448242168382;        Sun, 22 Nov 2015 17:29:28 -0800 (PST)
Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53])        by smtp.gmail.com with ESMTPSA id xi8sm8005858pab.9.2015.11.22.17.29.27        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Sun, 22 Nov 2015 17:29:27 -0800 (PST)
From: Doug Evans <xdje42@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] building on musl: #include sys/types.h for mode_t
References: <86ziz27urp.fsf@sspiff.org> <56310C96.5050709@redhat.com>	<563112BD.60505@redhat.com>
Date: Mon, 23 Nov 2015 01:29:00 -0000
In-Reply-To: <563112BD.60505@redhat.com> (Pedro Alves's message of "Wed, 28	Oct 2015 18:23:57 +0000")
Message-ID: <m3lh9ptsgl.fsf@sspiff.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg00456.txt.bz2

Pedro Alves <palves@redhat.com> writes:
> On 10/28/2015 05:57 PM, Pedro Alves wrote:
>> On 10/28/2015 05:44 PM, Doug Evans wrote:
>>> Hi.
>> 
>> Hi there,
>> 
>>>
>>> Turns out there was a fourth patch. :-)
>> 
>> :-)
>> 
>>>
>>> 2015-10-28  Doug Evans  <xdje42@gmail.com>
>>>
>>> 	* target.h: #include <sys/types.h>
>>>
>>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>>> index a14c6ff..f3fcd6c 100644
>>> --- a/gdb/gdbserver/target.h
>>> +++ b/gdb/gdbserver/target.h
>>> @@ -21,6 +21,7 @@
>>>  #ifndef TARGET_H
>>>  #define TARGET_H
>>>  
>>> +#include <sys/types.h> /* for mode_t */
>> 
>> Where is mode_t referenced? (what's the error?)
>
> Nevermind, I didn't notice I was was grepping an old tree,
> which predates target->multifs_open.
>
> Patch LGTM.
>
> Thanks,
> Pedro Alves

Committed, thanks.