* [PATCH] Fix make_cleanup_dtor signature to match declaration
@ 2014-12-02 22:32 Simon Marchi
2014-12-03 3:56 ` Joel Brobecker
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2014-12-02 22:32 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
The definition does not use the typedef for the dtor function pointer
type that the declaration uses. It's a cosmetic-only change.
ChangeLog:
* common/cleanups.c (make_cleanup_dtor): Use typedef for dtor
type.
---
gdb/common/cleanups.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/common/cleanups.c b/gdb/common/cleanups.c
index 80271fd..8678114 100644
--- a/gdb/common/cleanups.c
+++ b/gdb/common/cleanups.c
@@ -124,7 +124,7 @@ make_cleanup (make_cleanup_ftype *function, void *arg)
struct cleanup *
make_cleanup_dtor (make_cleanup_ftype *function, void *arg,
- void (*dtor) (void *))
+ make_cleanup_dtor_ftype *dtor)
{
return make_my_cleanup2 (&cleanup_chain,
function, arg, dtor);
--
2.1.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix make_cleanup_dtor signature to match declaration
2014-12-02 22:32 [PATCH] Fix make_cleanup_dtor signature to match declaration Simon Marchi
@ 2014-12-03 3:56 ` Joel Brobecker
2014-12-03 13:57 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2014-12-03 3:56 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
> The definition does not use the typedef for the dtor function pointer
> type that the declaration uses. It's a cosmetic-only change.
>
> ChangeLog:
>
> * common/cleanups.c (make_cleanup_dtor): Use typedef for dtor
> type.
I would argue that this goes beyong cosmetic-only in terms of
the benefits, so quite desirable. This is OK.
Thank you!
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix make_cleanup_dtor signature to match declaration
2014-12-03 3:56 ` Joel Brobecker
@ 2014-12-03 13:57 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2014-12-03 13:57 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
On 2014-12-02 10:55 PM, Joel Brobecker wrote:
>> The definition does not use the typedef for the dtor function pointer
>> type that the declaration uses. It's a cosmetic-only change.
>>
>> ChangeLog:
>>
>> * common/cleanups.c (make_cleanup_dtor): Use typedef for dtor
>> type.
>
> I would argue that this goes beyong cosmetic-only in terms of
> the benefits, so quite desirable. This is OK.
>
> Thank you!
Thanks, pushed!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-03 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-02 22:32 [PATCH] Fix make_cleanup_dtor signature to match declaration Simon Marchi
2014-12-03 3:56 ` Joel Brobecker
2014-12-03 13:57 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox