From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 590 invoked by alias); 3 Dec 2014 03:56:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 578 invoked by uid 89); 3 Dec 2014 03:56:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 03 Dec 2014 03:55:59 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 088CC11675E; Tue, 2 Dec 2014 22:55:58 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AEm5fJ+rZuww; Tue, 2 Dec 2014 22:55:57 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A4C4F116742; Tue, 2 Dec 2014 22:55:57 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D2C1546B66; Wed, 3 Dec 2014 07:55:50 +0400 (RET) Date: Wed, 03 Dec 2014 03:56:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix make_cleanup_dtor signature to match declaration Message-ID: <20141203035550.GK4882@adacore.com> References: <1417559541-32531-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417559541-32531-1-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00052.txt.bz2 > The definition does not use the typedef for the dtor function pointer > type that the declaration uses. It's a cosmetic-only change. > > ChangeLog: > > * common/cleanups.c (make_cleanup_dtor): Use typedef for dtor > type. I would argue that this goes beyong cosmetic-only in terms of the benefits, so quite desirable. This is OK. Thank you! -- Joel