From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118027-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29452 invoked by alias); 3 Dec 2014 13:57:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29442 invoked by uid 89); 3 Dec 2014 13:57:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: usevmg21.ericsson.net
Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 03 Dec 2014 13:57:16 +0000
Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78])	by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 0B.FC.25146.68ABE745; Wed,  3 Dec 2014 08:23:50 +0100 (CET)
Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 3 Dec 2014 08:57:13 -0500
Message-ID: <547F16B9.4040308@ericsson.com>
Date: Wed, 03 Dec 2014 13:57:00 -0000
From: Simon Marchi <simon.marchi@ericsson.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix make_cleanup_dtor signature to match declaration
References: <1417559541-32531-1-git-send-email-simon.marchi@ericsson.com> <20141203035550.GK4882@adacore.com>
In-Reply-To: <20141203035550.GK4882@adacore.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2014-12/txt/msg00060.txt.bz2

On 2014-12-02 10:55 PM, Joel Brobecker wrote:
>> The definition does not use the typedef for the dtor function pointer
>> type that the declaration uses.  It's a cosmetic-only change.
>>
>> ChangeLog:
>>
>> 	* common/cleanups.c (make_cleanup_dtor): Use typedef for dtor
>> 	type.
> 
> I would argue that this goes beyong cosmetic-only in terms of
> the benefits, so quite desirable. This is OK.
> 
> Thank you!

Thanks, pushed!