From: Simon Marchi <simon.marchi@ericsson.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix make_cleanup_dtor signature to match declaration
Date: Wed, 03 Dec 2014 13:57:00 -0000 [thread overview]
Message-ID: <547F16B9.4040308@ericsson.com> (raw)
In-Reply-To: <20141203035550.GK4882@adacore.com>
On 2014-12-02 10:55 PM, Joel Brobecker wrote:
>> The definition does not use the typedef for the dtor function pointer
>> type that the declaration uses. It's a cosmetic-only change.
>>
>> ChangeLog:
>>
>> * common/cleanups.c (make_cleanup_dtor): Use typedef for dtor
>> type.
>
> I would argue that this goes beyong cosmetic-only in terms of
> the benefits, so quite desirable. This is OK.
>
> Thank you!
Thanks, pushed!
prev parent reply other threads:[~2014-12-03 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 22:32 Simon Marchi
2014-12-03 3:56 ` Joel Brobecker
2014-12-03 13:57 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F16B9.4040308@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox