Re: [PATCH 06/11 v5] Add target/symbol.h

[Pedro Alves <palves@redhat.com>]

On 08/01/2014 11:19 AM, Gary Benson wrote:
> This adds target/symbol.h.  This file declares a function that the
> shared code can use and that the clients must implement.  It also
> changes some shared code to use these functions.

A small parens:

I have to say that calling this new method target_foo looks kind of
awkward to me.  Unlike other target methods and helpers, that extract
info out of the target or tell the target to do something,
this goes in the other direction -- this is the target/backend/server
calling back to the client/symbol side for something.  Put another way,
seems like this method would never ultimately go through target_ops.

Thanks,
Pedro Alves