Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Doug Evans <dje@google.com>
Subject: Re: [PATCH 06/11 v5] Add target/symbol.h
Date: Wed, 20 Aug 2014 12:14:00 -0000	[thread overview]
Message-ID: <20140820121403.GB26854@blade.nx> (raw)
In-Reply-To: <53F48372.2080703@redhat.com>

Pedro Alves wrote:
> On 08/01/2014 11:19 AM, Gary Benson wrote:
> > This adds target/symbol.h.  This file declares a function that the
> > shared code can use and that the clients must implement.  It also
> > changes some shared code to use these functions.
> 
> A small parens:
> 
> I have to say that calling this new method target_foo looks kind
> of awkward to me.  Unlike other target methods and helpers, that
> extract info out of the target or tell the target to do something,
> this goes in the other direction -- this is the target/backend/
> server calling back to the client/symbol side for something.  Put
> another way, seems like this method would never ultimately go
> through target_ops.

Can you suggest a more suitable name?

Thanks,
Gary

-- 
http://gbenson.net/


  reply	other threads:[~2014-08-20 12:14 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 10:19 [PATCH 00/11 v5] Common code cleanups Gary Benson
2014-08-01 10:19 ` [PATCH 04/11 v5] Introduce and use debug_printf and debug_vprintf Gary Benson
2014-08-06 17:08   ` Doug Evans
2014-08-07  9:22     ` Gary Benson
2014-08-01 10:19 ` [PATCH 02/11 v5] Introduce common-types.h Gary Benson
2014-08-06 16:34   ` Doug Evans
2014-08-01 10:19 ` [PATCH 03/11 v5] Move print-utils.h to common-defs.h Gary Benson
2014-08-06 16:51   ` Doug Evans
2014-08-06 17:05     ` Gary Benson
2014-08-01 10:22 ` [PATCH 07/11 v5] Introduce get_thread_regcache_for_ptid Gary Benson
2014-08-06 18:15   ` Doug Evans
2014-08-01 10:22 ` [PATCH 09/11 v5] Remove GDBSERVER uses from linux-btrace.c Gary Benson
2014-08-06 18:27   ` Doug Evans
2014-08-01 10:27 ` [PATCH 10/11 v5] Remove GDBSERVER uses from i386-dregs.c Gary Benson
2014-08-06 18:32   ` Doug Evans
2014-08-07 12:28     ` Gary Benson
2014-08-01 10:27 ` [PATCH 08/11 v5] Include common-defs.h instead of defs.h/server.h in shared code Gary Benson
2014-08-06 18:16   ` Doug Evans
2014-08-01 10:28 ` [PATCH 06/11 v5] Add target/symbol.h Gary Benson
2014-08-06 18:08   ` Doug Evans
2014-08-07 10:42     ` Gary Benson
2014-08-20 11:16   ` Pedro Alves
2014-08-20 12:14     ` Gary Benson [this message]
2014-08-20 14:17       ` Pedro Alves
2014-08-01 10:28 ` [PATCH 05/11 v5] Add target/target.h Gary Benson
2014-08-06 17:49   ` Doug Evans
2014-08-07 13:48     ` Gary Benson
2014-08-20 14:49       ` Pedro Alves
2014-08-20 15:01         ` Gary Benson
2014-08-20 15:08           ` Pedro Alves
2014-08-20 12:00   ` Pedro Alves
2014-08-20 12:01   ` Pedro Alves
2014-08-20 13:38     ` Gary Benson
2014-08-01 10:30 ` [PATCH 01/11 v5] Introduce common/errors.h Gary Benson
2014-08-06 16:20   ` Doug Evans
2014-08-06 16:29     ` Gary Benson
2014-08-06 16:40       ` Doug Evans
2014-08-01 10:41 ` [PATCH 11/11 v5] Remove one GDBSERVER use from linux-waitpid.c Gary Benson
2014-08-06 18:35   ` Doug Evans
2014-08-07 12:39     ` Gary Benson
2014-08-20 15:04       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140820121403.GB26854@blade.nx \
    --to=gbenson@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox