Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Cc: Doug Evans <dje@google.com>, Pedro Alves <palves@redhat.com>,
	       Tom Tromey <tromey@redhat.com>
Subject: [PATCH 00/11 v5] Common code cleanups
Date: Fri, 01 Aug 2014 10:19:00 -0000	[thread overview]
Message-ID: <1406888377-25795-1-git-send-email-gbenson@redhat.com> (raw)

Hi all,

This series contains updated versions of the common code cleanups
patches I've posted previously.  These have been reworked (in some
cases recreated) to apply on top of my "Include some headers in
common-defs.h" series that is currently under review [1, 2].

Current gdb/master has 32 uses of "#ifdef GDBSERVER".  This series
reduces that count to three:

  - One in common/common-defs.h, to select the appropriate gnulib
    config.h.  This use can be removed when the build is modified
    to build only one copy of gnulib.

  - One in common/common-types.h, to define types based on BFD's
    types (for GDB) or otherwise (for gdbserver).  I'm not sure
    what form removing this use would take.

  - One in linux-waitpid.c to protect some gdbserver-specific
    thread debugging code which can be removed when the Linux
    thread_db code is unified and made shared.

All built and regtested on x86-64 RHEL6.5.  mips-linux-watch.h
changes checked by cross-building gdbserver with the Sourcery
CodeBench for MIPS GNU/Linux toolchain.

If this series is approved I will update the "Include Files" section
of the Coding Standards page [3] to insert the following line after
the existing first line:

  "All .c files under gdb/common/, gdb/nat/ and gdb/target/ must
  include common-defs.h as their first non-comment line."

I will also update the subsequent mentions of common-defs.h
accordingly.

Is this ok to commit?

Thanks,
Gary

--
[1] https://sourceware.org/ml/gdb-patches/2014-07/msg00736.html
[2] https://sourceware.org/ml/gdb-patches/2014-07/msg00820.html
[3] https://sourceware.org/gdb/wiki/Internals GDB-C-Coding-Standards


             reply	other threads:[~2014-08-01 10:19 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 10:19 Gary Benson [this message]
2014-08-01 10:19 ` [PATCH 04/11 v5] Introduce and use debug_printf and debug_vprintf Gary Benson
2014-08-06 17:08   ` Doug Evans
2014-08-07  9:22     ` Gary Benson
2014-08-01 10:19 ` [PATCH 02/11 v5] Introduce common-types.h Gary Benson
2014-08-06 16:34   ` Doug Evans
2014-08-01 10:19 ` [PATCH 03/11 v5] Move print-utils.h to common-defs.h Gary Benson
2014-08-06 16:51   ` Doug Evans
2014-08-06 17:05     ` Gary Benson
2014-08-01 10:22 ` [PATCH 07/11 v5] Introduce get_thread_regcache_for_ptid Gary Benson
2014-08-06 18:15   ` Doug Evans
2014-08-01 10:22 ` [PATCH 09/11 v5] Remove GDBSERVER uses from linux-btrace.c Gary Benson
2014-08-06 18:27   ` Doug Evans
2014-08-01 10:27 ` [PATCH 08/11 v5] Include common-defs.h instead of defs.h/server.h in shared code Gary Benson
2014-08-06 18:16   ` Doug Evans
2014-08-01 10:27 ` [PATCH 10/11 v5] Remove GDBSERVER uses from i386-dregs.c Gary Benson
2014-08-06 18:32   ` Doug Evans
2014-08-07 12:28     ` Gary Benson
2014-08-01 10:28 ` [PATCH 06/11 v5] Add target/symbol.h Gary Benson
2014-08-06 18:08   ` Doug Evans
2014-08-07 10:42     ` Gary Benson
2014-08-20 11:16   ` Pedro Alves
2014-08-20 12:14     ` Gary Benson
2014-08-20 14:17       ` Pedro Alves
2014-08-01 10:28 ` [PATCH 05/11 v5] Add target/target.h Gary Benson
2014-08-06 17:49   ` Doug Evans
2014-08-07 13:48     ` Gary Benson
2014-08-20 14:49       ` Pedro Alves
2014-08-20 15:01         ` Gary Benson
2014-08-20 15:08           ` Pedro Alves
2014-08-20 12:00   ` Pedro Alves
2014-08-20 12:01   ` Pedro Alves
2014-08-20 13:38     ` Gary Benson
2014-08-01 10:30 ` [PATCH 01/11 v5] Introduce common/errors.h Gary Benson
2014-08-06 16:20   ` Doug Evans
2014-08-06 16:29     ` Gary Benson
2014-08-06 16:40       ` Doug Evans
2014-08-01 10:41 ` [PATCH 11/11 v5] Remove one GDBSERVER use from linux-waitpid.c Gary Benson
2014-08-06 18:35   ` Doug Evans
2014-08-07 12:39     ` Gary Benson
2014-08-20 15:04       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406888377-25795-1-git-send-email-gbenson@redhat.com \
    --to=gbenson@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox