From: Doug Evans <dje@google.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>,
Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 08/11 v5] Include common-defs.h instead of defs.h/server.h in shared code
Date: Wed, 06 Aug 2014 18:16:00 -0000 [thread overview]
Message-ID: <21474.28928.858022.514774@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <1406888377-25795-9-git-send-email-gbenson@redhat.com>
Gary Benson writes:
> This commit makes 19 of the 22 shared .c files in common, nat and
> target include common-defs.h instead of defs.h/server.h. The
> remaining three files need slight extra work and are dealt with
> in separate commits.
>
> gdb/
> 2014-08-01 Gary Benson <gbenson@redhat.com>
>
> * common/agent.c: Include common-defs.h.
> Don't include defs.h or server.h.
> * common/buffer.c: Likewise.
> * common/common-debug.c: Likewise.
> * common/common-utils.c: Likewise.
> * common/errors.c: Likewise.
> * common/filestuff.c: Likewise.
> * common/format.c: Likewise.
> * common/gdb_vecs.c: Likewise.
> * common/print-utils.c: Likewise.
> * common/ptid.c: Likewise.
> * common/rsp-low.c: Likewise.
> * common/signals.c: Likewise.
> * common/vec.c: Likewise.
> * common/xml-utils.c: Likewise.
> * nat/linux-osdata.c: Likewise.
> * nat/linux-procfs.c: Likewise.
> * nat/linux-ptrace.c: Likewise.
> * nat/mips-linux-watch.c: Likewise.
> * target/waitstatus.c: Likewise.
LGTM
next prev parent reply other threads:[~2014-08-06 18:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 10:19 [PATCH 00/11 v5] Common code cleanups Gary Benson
2014-08-01 10:19 ` [PATCH 03/11 v5] Move print-utils.h to common-defs.h Gary Benson
2014-08-06 16:51 ` Doug Evans
2014-08-06 17:05 ` Gary Benson
2014-08-01 10:19 ` [PATCH 02/11 v5] Introduce common-types.h Gary Benson
2014-08-06 16:34 ` Doug Evans
2014-08-01 10:19 ` [PATCH 04/11 v5] Introduce and use debug_printf and debug_vprintf Gary Benson
2014-08-06 17:08 ` Doug Evans
2014-08-07 9:22 ` Gary Benson
2014-08-01 10:22 ` [PATCH 09/11 v5] Remove GDBSERVER uses from linux-btrace.c Gary Benson
2014-08-06 18:27 ` Doug Evans
2014-08-01 10:22 ` [PATCH 07/11 v5] Introduce get_thread_regcache_for_ptid Gary Benson
2014-08-06 18:15 ` Doug Evans
2014-08-01 10:27 ` [PATCH 10/11 v5] Remove GDBSERVER uses from i386-dregs.c Gary Benson
2014-08-06 18:32 ` Doug Evans
2014-08-07 12:28 ` Gary Benson
2014-08-01 10:27 ` [PATCH 08/11 v5] Include common-defs.h instead of defs.h/server.h in shared code Gary Benson
2014-08-06 18:16 ` Doug Evans [this message]
2014-08-01 10:28 ` [PATCH 05/11 v5] Add target/target.h Gary Benson
2014-08-06 17:49 ` Doug Evans
2014-08-07 13:48 ` Gary Benson
2014-08-20 14:49 ` Pedro Alves
2014-08-20 15:01 ` Gary Benson
2014-08-20 15:08 ` Pedro Alves
2014-08-20 12:00 ` Pedro Alves
2014-08-20 12:01 ` Pedro Alves
2014-08-20 13:38 ` Gary Benson
2014-08-01 10:28 ` [PATCH 06/11 v5] Add target/symbol.h Gary Benson
2014-08-06 18:08 ` Doug Evans
2014-08-07 10:42 ` Gary Benson
2014-08-20 11:16 ` Pedro Alves
2014-08-20 12:14 ` Gary Benson
2014-08-20 14:17 ` Pedro Alves
2014-08-01 10:30 ` [PATCH 01/11 v5] Introduce common/errors.h Gary Benson
2014-08-06 16:20 ` Doug Evans
2014-08-06 16:29 ` Gary Benson
2014-08-06 16:40 ` Doug Evans
2014-08-01 10:41 ` [PATCH 11/11 v5] Remove one GDBSERVER use from linux-waitpid.c Gary Benson
2014-08-06 18:35 ` Doug Evans
2014-08-07 12:39 ` Gary Benson
2014-08-20 15:04 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21474.28928.858022.514774@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox