From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32092 invoked by alias); 6 Aug 2014 18:16:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31876 invoked by uid 89); 6 Aug 2014 18:16:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f73.google.com Received: from mail-oi0-f73.google.com (HELO mail-oi0-f73.google.com) (209.85.218.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 06 Aug 2014 18:16:36 +0000 Received: by mail-oi0-f73.google.com with SMTP id u20so539799oif.2 for ; Wed, 06 Aug 2014 11:16:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=YhS/Mssws1WqYfNDwVGcRlbgtRTPaazWRb072CFvtig=; b=a7tB4bjKRDhBv5Pr6mm3s6QdLo3jjnLXMDH2s7fi1aewc2pCubvQWUYIVBM2VgpKBv ZFqUI0SnW74qGJTn2epFMcuBZWEKA9jdL1+alG5iRT22f5Zk7RJC4dNNCGpitvsdvtqI 7SXiQl54Yrrt3Lbz683fBESZttdm3KiG4weV4HuOcquGWakrluwRuuaSC3hlzErKK/RS k0OSpjOMLH5ZRqB6XIi/2vlqcSjnpmxA0on/Q/9N7+wVQmDNVQFnLTUr6b0hIARjFWWV HO3WKjXqmkLitfsxnSSFkZsYpMiF0vovrbr52PR6FAuSUh16gMg4/K0wKBRMwW5A8YSe Cg2w== X-Gm-Message-State: ALoCoQl6qE70aQ1fTbWiyA1sRoGUS7+NgmwxVCNs8uJMfh7PESxtXEfer+oDOMIZTO+Rario/2lR X-Received: by 10.43.17.134 with SMTP id qc6mr7292354icb.3.1407348994280; Wed, 06 Aug 2014 11:16:34 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id o69si114143yhp.6.2014.08.06.11.16.34 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Aug 2014 11:16:34 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 6387A5A44EE; Wed, 6 Aug 2014 11:16:33 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21474.28928.858022.514774@ruffy.mtv.corp.google.com> Date: Wed, 06 Aug 2014 18:16:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 08/11 v5] Include common-defs.h instead of defs.h/server.h in shared code In-Reply-To: <1406888377-25795-9-git-send-email-gbenson@redhat.com> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-9-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00114.txt.bz2 Gary Benson writes: > This commit makes 19 of the 22 shared .c files in common, nat and > target include common-defs.h instead of defs.h/server.h. The > remaining three files need slight extra work and are dealt with > in separate commits. > > gdb/ > 2014-08-01 Gary Benson > > * common/agent.c: Include common-defs.h. > Don't include defs.h or server.h. > * common/buffer.c: Likewise. > * common/common-debug.c: Likewise. > * common/common-utils.c: Likewise. > * common/errors.c: Likewise. > * common/filestuff.c: Likewise. > * common/format.c: Likewise. > * common/gdb_vecs.c: Likewise. > * common/print-utils.c: Likewise. > * common/ptid.c: Likewise. > * common/rsp-low.c: Likewise. > * common/signals.c: Likewise. > * common/vec.c: Likewise. > * common/xml-utils.c: Likewise. > * nat/linux-osdata.c: Likewise. > * nat/linux-procfs.c: Likewise. > * nat/linux-ptrace.c: Likewise. > * nat/mips-linux-watch.c: Likewise. > * target/waitstatus.c: Likewise. LGTM