From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14392 invoked by alias); 1 Aug 2014 10:19:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14373 invoked by uid 89); 1 Aug 2014 10:19:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 01 Aug 2014 10:19:48 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s71AJjKm028602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Aug 2014 06:19:46 -0400 Received: from blade.nx (ovpn-116-104.ams2.redhat.com [10.36.116.104]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s71AJidi027898; Fri, 1 Aug 2014 06:19:45 -0400 Received: from blade.nx (localhost [127.0.0.1]) by blade.nx (Postfix) with ESMTP id 40F492640D4; Fri, 1 Aug 2014 11:19:44 +0100 (BST) From: Gary Benson To: gdb-patches@sourceware.org Cc: Doug Evans , Pedro Alves , Tom Tromey Subject: [PATCH 00/11 v5] Common code cleanups Date: Fri, 01 Aug 2014 10:19:00 -0000 Message-Id: <1406888377-25795-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00007.txt.bz2 Hi all, This series contains updated versions of the common code cleanups patches I've posted previously. These have been reworked (in some cases recreated) to apply on top of my "Include some headers in common-defs.h" series that is currently under review [1, 2]. Current gdb/master has 32 uses of "#ifdef GDBSERVER". This series reduces that count to three: - One in common/common-defs.h, to select the appropriate gnulib config.h. This use can be removed when the build is modified to build only one copy of gnulib. - One in common/common-types.h, to define types based on BFD's types (for GDB) or otherwise (for gdbserver). I'm not sure what form removing this use would take. - One in linux-waitpid.c to protect some gdbserver-specific thread debugging code which can be removed when the Linux thread_db code is unified and made shared. All built and regtested on x86-64 RHEL6.5. mips-linux-watch.h changes checked by cross-building gdbserver with the Sourcery CodeBench for MIPS GNU/Linux toolchain. If this series is approved I will update the "Include Files" section of the Coding Standards page [3] to insert the following line after the existing first line: "All .c files under gdb/common/, gdb/nat/ and gdb/target/ must include common-defs.h as their first non-comment line." I will also update the subsequent mentions of common-defs.h accordingly. Is this ok to commit? Thanks, Gary -- [1] https://sourceware.org/ml/gdb-patches/2014-07/msg00736.html [2] https://sourceware.org/ml/gdb-patches/2014-07/msg00820.html [3] https://sourceware.org/gdb/wiki/Internals GDB-C-Coding-Standards