From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18729 invoked by alias); 20 Aug 2014 12:14:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18713 invoked by uid 89); 20 Aug 2014 12:14:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 12:14:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KCE46I004474 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 08:14:04 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KCE3CE020213; Wed, 20 Aug 2014 08:14:04 -0400 Received: by blade.nx (Postfix, from userid 1000) id 3AB2B2640D5; Wed, 20 Aug 2014 13:14:03 +0100 (BST) Date: Wed, 20 Aug 2014 12:14:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org, Doug Evans Subject: Re: [PATCH 06/11 v5] Add target/symbol.h Message-ID: <20140820121403.GB26854@blade.nx> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-7-git-send-email-gbenson@redhat.com> <53F48372.2080703@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53F48372.2080703@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00397.txt.bz2 Pedro Alves wrote: > On 08/01/2014 11:19 AM, Gary Benson wrote: > > This adds target/symbol.h. This file declares a function that the > > shared code can use and that the clients must implement. It also > > changes some shared code to use these functions. > > A small parens: > > I have to say that calling this new method target_foo looks kind > of awkward to me. Unlike other target methods and helpers, that > extract info out of the target or tell the target to do something, > this goes in the other direction -- this is the target/backend/ > server calling back to the client/symbol side for something. Put > another way, seems like this method would never ultimately go > through target_ops. Can you suggest a more suitable name? Thanks, Gary -- http://gbenson.net/