From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22454 invoked by alias); 20 Aug 2014 11:16:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22441 invoked by uid 89); 20 Aug 2014 11:16:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 11:16:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KBG5Rw002949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 07:16:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KBG3Oa016518; Wed, 20 Aug 2014 07:16:03 -0400 Message-ID: <53F48372.2080703@redhat.com> Date: Wed, 20 Aug 2014 11:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Doug Evans , Tom Tromey Subject: Re: [PATCH 06/11 v5] Add target/symbol.h References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-7-git-send-email-gbenson@redhat.com> In-Reply-To: <1406888377-25795-7-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00392.txt.bz2 On 08/01/2014 11:19 AM, Gary Benson wrote: > This adds target/symbol.h. This file declares a function that the > shared code can use and that the clients must implement. It also > changes some shared code to use these functions. A small parens: I have to say that calling this new method target_foo looks kind of awkward to me. Unlike other target methods and helpers, that extract info out of the target or tell the target to do something, this goes in the other direction -- this is the target/backend/server calling back to the client/symbol side for something. Put another way, seems like this method would never ultimately go through target_ops. Thanks, Pedro Alves