From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/8] remove some stale FIXMEs
Date: Wed, 27 Nov 2013 12:25:00 -0000 [thread overview]
Message-ID: <5295D6FC.7030508@redhat.com> (raw)
In-Reply-To: <1385502587-29757-5-git-send-email-tromey@redhat.com>
On 11/26/2013 09:49 PM, Tom Tromey wrote:
> This removes a couple of old "32x64" FIXME comments that are no longer
> true -- the code they annotate is correct now.
Not really true. unsigned long is usually 32-bit on 32-bit hosts.
So on 32x64 (32-bit host, 64-bit target), the unsigned long casts
trim the target address to 32-bit.
The casts should be removed, or even better, the hex_string
calls replaced by:
paddress (get_current_arch (), sal.pc))
>
> if (sal.symtab == 0)
> - /* FIXME-32x64--assumes sal.pc fits in long. */
> error (_("No source file for address %s."),
> hex_string ((unsigned long) sal.pc));
>
> @@ -982,7 +981,6 @@ list_command (char *arg, int from_tty)
> struct gdbarch *gdbarch;
>
> if (sal.symtab == 0)
> - /* FIXME-32x64--assumes sal.pc fits in long. */
> error (_("No source file for address %s."),
> hex_string ((unsigned long) sal.pc));
>
--
Pedro Alves
next prev parent reply other threads:[~2013-11-27 11:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 21:50 [PATCH 0/8] trivia Tom Tromey
2013-11-26 21:50 ` [PATCH 2/8] make symtab::dirname const Tom Tromey
2013-11-26 21:57 ` [PATCH 1/8] make symtab::filename const Tom Tromey
2013-11-26 22:12 ` [PATCH 3/8] put the psymtab filename in the filename bcache Tom Tromey
2013-11-26 22:27 ` [PATCH 8/8] update free_objfile comment Tom Tromey
2013-11-26 22:37 ` [PATCH 7/8] remove objfile_to_front Tom Tromey
2013-11-26 22:44 ` [PATCH 5/8] pack partial_symtab for space Tom Tromey
2013-11-27 8:34 ` [PATCH 6/8] remove unnecessary declaration Tom Tromey
2013-11-27 9:49 ` [PATCH 4/8] remove some stale FIXMEs Tom Tromey
2013-11-27 12:25 ` Pedro Alves [this message]
2013-11-27 15:56 ` Tom Tromey
2013-11-27 17:21 ` Tom Tromey
2013-11-27 17:52 ` Pedro Alves
2013-12-06 19:12 ` [PATCH 0/8] trivia Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295D6FC.7030508@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox