Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH 2/8] make symtab::dirname const
Date: Tue, 26 Nov 2013 21:50:00 -0000	[thread overview]
Message-ID: <1385502587-29757-3-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1385502587-29757-1-git-send-email-tromey@redhat.com>

This makes symtab::dirname const and updates one spot to avoid an
intermediate constless result.

2013-11-26  Tom Tromey  <tromey@redhat.com>

	* buildsym.c (end_symtab_from_static_block): Use obstack_copy0.
	* symtab.h (struct symtab) <dirname>: Now const.
---
 gdb/ChangeLog  | 5 +++++
 gdb/buildsym.c | 8 ++++----
 gdb/symtab.h   | 2 +-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/gdb/buildsym.c b/gdb/buildsym.c
index 0326e26..8d9bdb1 100644
--- a/gdb/buildsym.c
+++ b/gdb/buildsym.c
@@ -1204,10 +1204,10 @@ end_symtab_from_static_block (struct block *static_block,
 	  if (subfile->dirname)
 	    {
 	      /* Reallocate the dirname on the symbol obstack.  */
-	      symtab->dirname = (char *)
-		obstack_alloc (&objfile->objfile_obstack,
-			       strlen (subfile->dirname) + 1);
-	      strcpy (symtab->dirname, subfile->dirname);
+	      symtab->dirname =
+		obstack_copy0 (&objfile->objfile_obstack,
+			       subfile->dirname,
+			       strlen (subfile->dirname));
 	    }
 	  else
 	    {
diff --git a/gdb/symtab.h b/gdb/symtab.h
index 821479a..3be85ca 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -879,7 +879,7 @@ struct symtab
 
   /* Directory in which it was compiled, or NULL if we don't know.  */
 
-  char *dirname;
+  const char *dirname;
 
   /* Total number of lines found in source file.  */
 
-- 
1.8.1.4


  reply	other threads:[~2013-11-26 21:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 21:50 [PATCH 0/8] trivia Tom Tromey
2013-11-26 21:50 ` Tom Tromey [this message]
2013-11-26 21:57 ` [PATCH 1/8] make symtab::filename const Tom Tromey
2013-11-26 22:12 ` [PATCH 3/8] put the psymtab filename in the filename bcache Tom Tromey
2013-11-26 22:27 ` [PATCH 8/8] update free_objfile comment Tom Tromey
2013-11-26 22:37 ` [PATCH 7/8] remove objfile_to_front Tom Tromey
2013-11-26 22:44 ` [PATCH 5/8] pack partial_symtab for space Tom Tromey
2013-11-27  8:34 ` [PATCH 6/8] remove unnecessary declaration Tom Tromey
2013-11-27  9:49 ` [PATCH 4/8] remove some stale FIXMEs Tom Tromey
2013-11-27 12:25   ` Pedro Alves
2013-11-27 15:56     ` Tom Tromey
2013-11-27 17:21       ` Tom Tromey
2013-11-27 17:52         ` Pedro Alves
2013-12-06 19:12 ` [PATCH 0/8] trivia Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385502587-29757-3-git-send-email-tromey@redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox