Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH 8/8] update free_objfile comment
Date: Tue, 26 Nov 2013 22:27:00 -0000	[thread overview]
Message-ID: <1385502587-29757-9-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1385502587-29757-1-git-send-email-tromey@redhat.com>

The introductory comment to free_objfile is obsolete.
This patch fixes it by removing all the obsolete bits.

2013-11-26  Tom Tromey  <tromey@redhat.com>

	* objfiles.c (free_objfile): Update comment.
---
 gdb/ChangeLog  |  4 ++++
 gdb/objfiles.c | 16 +---------------
 2 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/gdb/objfiles.c b/gdb/objfiles.c
index e8d641f..4f84ff6 100644
--- a/gdb/objfiles.c
+++ b/gdb/objfiles.c
@@ -509,21 +509,7 @@ free_objfile_separate_debug (struct objfile *objfile)
     }
 }
 
-/* Destroy an objfile and all the symtabs and psymtabs under it.  Note
-   that as much as possible is allocated on the objfile_obstack 
-   so that the memory can be efficiently freed.
-
-   Things which we do NOT free because they are not in malloc'd memory
-   or not in memory specific to the objfile include:
-
-   objfile -> sf
-
-   FIXME:  If the objfile is using reusable symbol information (via mmalloc),
-   then we need to take into account the fact that more than one process
-   may be using the symbol information at the same time (when mmalloc is
-   extended to support cooperative locking).  When more than one process
-   is using the mapped symbol info, we need to be more careful about when
-   we free objects in the reusable area.  */
+/* Destroy an objfile and all the symtabs and psymtabs under it.  */
 
 void
 free_objfile (struct objfile *objfile)
-- 
1.8.1.4


  parent reply	other threads:[~2013-11-26 21:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 21:50 [PATCH 0/8] trivia Tom Tromey
2013-11-26 21:50 ` [PATCH 2/8] make symtab::dirname const Tom Tromey
2013-11-26 21:57 ` [PATCH 1/8] make symtab::filename const Tom Tromey
2013-11-26 22:12 ` [PATCH 3/8] put the psymtab filename in the filename bcache Tom Tromey
2013-11-26 22:27 ` Tom Tromey [this message]
2013-11-26 22:37 ` [PATCH 7/8] remove objfile_to_front Tom Tromey
2013-11-26 22:44 ` [PATCH 5/8] pack partial_symtab for space Tom Tromey
2013-11-27  8:34 ` [PATCH 6/8] remove unnecessary declaration Tom Tromey
2013-11-27  9:49 ` [PATCH 4/8] remove some stale FIXMEs Tom Tromey
2013-11-27 12:25   ` Pedro Alves
2013-11-27 15:56     ` Tom Tromey
2013-11-27 17:21       ` Tom Tromey
2013-11-27 17:52         ` Pedro Alves
2013-12-06 19:12 ` [PATCH 0/8] trivia Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385502587-29757-9-git-send-email-tromey@redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox