From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH 5/8] pack partial_symtab for space
Date: Tue, 26 Nov 2013 22:44:00 -0000 [thread overview]
Message-ID: <1385502587-29757-6-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1385502587-29757-1-git-send-email-tromey@redhat.com>
This improves the packing of struct partial_symtab. I noticed with
pahole that were were a couple of holes. This consolidates the holes
without, I think, affecting readability -- it just moves the "user"
field a bit earlier in the struct. This change saves a small amount
of memory.
2013-11-26 Tom Tromey <tromey@redhat.com>
* psympriv.h (struct partial_symtab) <user>: Move earlier.
---
gdb/ChangeLog | 4 ++++
gdb/psympriv.h | 26 +++++++++++++-------------
2 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/gdb/psympriv.h b/gdb/psympriv.h
index 7a62bcc..9df687d 100644
--- a/gdb/psympriv.h
+++ b/gdb/psympriv.h
@@ -111,19 +111,6 @@ struct partial_symtab
CORE_ADDR textlow;
CORE_ADDR texthigh;
- /* Array of pointers to all of the partial_symtab's which this one
- depends on. Since this array can only be set to previous or
- the current (?) psymtab, this dependency tree is guaranteed not
- to have any loops. "depends on" means that symbols must be read
- for the dependencies before being read for this psymtab; this is
- for type references in stabs, where if foo.c includes foo.h, declarations
- in foo.h may use type numbers defined in foo.c. For other debugging
- formats there may be no need to use dependencies. */
-
- struct partial_symtab **dependencies;
-
- int number_of_dependencies;
-
/* If NULL, this is an ordinary partial symbol table.
If non-NULL, this holds a single includer of this partial symbol
@@ -153,6 +140,19 @@ struct partial_symtab
struct partial_symtab *user;
+ /* Array of pointers to all of the partial_symtab's which this one
+ depends on. Since this array can only be set to previous or
+ the current (?) psymtab, this dependency tree is guaranteed not
+ to have any loops. "depends on" means that symbols must be read
+ for the dependencies before being read for this psymtab; this is
+ for type references in stabs, where if foo.c includes foo.h, declarations
+ in foo.h may use type numbers defined in foo.c. For other debugging
+ formats there may be no need to use dependencies. */
+
+ struct partial_symtab **dependencies;
+
+ int number_of_dependencies;
+
/* Global symbol list. This list will be sorted after readin to
improve access. Binary search will be the usual method of
finding a symbol within it. globals_offset is an integer offset
--
1.8.1.4
next prev parent reply other threads:[~2013-11-26 22:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 21:50 [PATCH 0/8] trivia Tom Tromey
2013-11-26 21:50 ` [PATCH 2/8] make symtab::dirname const Tom Tromey
2013-11-26 21:57 ` [PATCH 1/8] make symtab::filename const Tom Tromey
2013-11-26 22:12 ` [PATCH 3/8] put the psymtab filename in the filename bcache Tom Tromey
2013-11-26 22:27 ` [PATCH 8/8] update free_objfile comment Tom Tromey
2013-11-26 22:37 ` [PATCH 7/8] remove objfile_to_front Tom Tromey
2013-11-26 22:44 ` Tom Tromey [this message]
2013-11-27 8:34 ` [PATCH 6/8] remove unnecessary declaration Tom Tromey
2013-11-27 9:49 ` [PATCH 4/8] remove some stale FIXMEs Tom Tromey
2013-11-27 12:25 ` Pedro Alves
2013-11-27 15:56 ` Tom Tromey
2013-11-27 17:21 ` Tom Tromey
2013-11-27 17:52 ` Pedro Alves
2013-12-06 19:12 ` [PATCH 0/8] trivia Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385502587-29757-6-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox