From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24409 invoked by alias); 26 Nov 2013 21:50:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24185 invoked by uid 89); 26 Nov 2013 21:50:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2013 21:50:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQLnqLr006935 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Nov 2013 16:49:53 -0500 Received: from barimba.redhat.com (ovpn-113-124.phx2.redhat.com [10.3.113.124]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAQLnprn008652; Tue, 26 Nov 2013 16:49:52 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 2/8] make symtab::dirname const Date: Tue, 26 Nov 2013 21:50:00 -0000 Message-Id: <1385502587-29757-3-git-send-email-tromey@redhat.com> In-Reply-To: <1385502587-29757-1-git-send-email-tromey@redhat.com> References: <1385502587-29757-1-git-send-email-tromey@redhat.com> X-SW-Source: 2013-11/txt/msg00828.txt.bz2 This makes symtab::dirname const and updates one spot to avoid an intermediate constless result. 2013-11-26 Tom Tromey * buildsym.c (end_symtab_from_static_block): Use obstack_copy0. * symtab.h (struct symtab) : Now const. --- gdb/ChangeLog | 5 +++++ gdb/buildsym.c | 8 ++++---- gdb/symtab.h | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gdb/buildsym.c b/gdb/buildsym.c index 0326e26..8d9bdb1 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -1204,10 +1204,10 @@ end_symtab_from_static_block (struct block *static_block, if (subfile->dirname) { /* Reallocate the dirname on the symbol obstack. */ - symtab->dirname = (char *) - obstack_alloc (&objfile->objfile_obstack, - strlen (subfile->dirname) + 1); - strcpy (symtab->dirname, subfile->dirname); + symtab->dirname = + obstack_copy0 (&objfile->objfile_obstack, + subfile->dirname, + strlen (subfile->dirname)); } else { diff --git a/gdb/symtab.h b/gdb/symtab.h index 821479a..3be85ca 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -879,7 +879,7 @@ struct symtab /* Directory in which it was compiled, or NULL if we don't know. */ - char *dirname; + const char *dirname; /* Total number of lines found in source file. */ -- 1.8.1.4