From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4181 invoked by alias); 27 Nov 2013 11:28:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4150 invoked by uid 89); 27 Nov 2013 11:28:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2013 11:27:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rARBQso1009059 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Nov 2013 06:26:54 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rARBQqZL011835; Wed, 27 Nov 2013 06:26:53 -0500 Message-ID: <5295D6FC.7030508@redhat.com> Date: Wed, 27 Nov 2013 12:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] remove some stale FIXMEs References: <1385502587-29757-1-git-send-email-tromey@redhat.com> <1385502587-29757-5-git-send-email-tromey@redhat.com> In-Reply-To: <1385502587-29757-5-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00838.txt.bz2 On 11/26/2013 09:49 PM, Tom Tromey wrote: > This removes a couple of old "32x64" FIXME comments that are no longer > true -- the code they annotate is correct now. Not really true. unsigned long is usually 32-bit on 32-bit hosts. So on 32x64 (32-bit host, 64-bit target), the unsigned long casts trim the target address to 32-bit. The casts should be removed, or even better, the hex_string calls replaced by: paddress (get_current_arch (), sal.pc)) > > if (sal.symtab == 0) > - /* FIXME-32x64--assumes sal.pc fits in long. */ > error (_("No source file for address %s."), > hex_string ((unsigned long) sal.pc)); > > @@ -982,7 +981,6 @@ list_command (char *arg, int from_tty) > struct gdbarch *gdbarch; > > if (sal.symtab == 0) > - /* FIXME-32x64--assumes sal.pc fits in long. */ > error (_("No source file for address %s."), > hex_string ((unsigned long) sal.pc)); > -- Pedro Alves